From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Umvff-0008Ia-7q for qemu-devel@nongnu.org; Wed, 12 Jun 2013 20:45:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Umvfb-0005Wy-Fn for qemu-devel@nongnu.org; Wed, 12 Jun 2013 20:45:46 -0400 Received: from cantor2.suse.de ([195.135.220.15]:32935 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Umvfa-0005WZ-Jq for qemu-devel@nongnu.org; Wed, 12 Jun 2013 20:45:43 -0400 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Thu, 13 Jun 2013 02:45:24 +0200 Message-Id: <1371084329-814-13-git-send-email-afaerber@suse.de> In-Reply-To: <1371084329-814-1-git-send-email-afaerber@suse.de> References: <1371084329-814-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 12/17] dump: Drop qmp_dump_guest_memory() stub and build for all targets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Andreas=20F=C3=A4rber?= , Luiz Capitulino qmp_dump_guest_memory() calls dump_init() and returns an Error when cpu_get_dump_info() returns an error, as done by the stub. So there is no need to have a stub for qmp_dump_guest_memory(). Enable the documentation of the always-present dump-guest-memory command. That way we can drop CONFIG_HAVE_CORE_DUMP and leave configure completely out of the picture for target CPU features. Signed-off-by: Andreas F=C3=A4rber --- Makefile.target | 2 +- configure | 4 ---- hmp-commands.hx | 2 -- stubs/dump.c | 8 -------- 4 files changed, 1 insertion(+), 15 deletions(-) diff --git a/Makefile.target b/Makefile.target index f9e1d89..b0be124 100644 --- a/Makefile.target +++ b/Makefile.target @@ -110,7 +110,7 @@ obj-$(CONFIG_FDT) +=3D device_tree.o obj-$(CONFIG_KVM) +=3D kvm-all.o obj-y +=3D memory.o savevm.o cputlb.o obj-y +=3D memory_mapping.o -obj-$(CONFIG_HAVE_CORE_DUMP) +=3D dump.o +obj-y +=3D dump.o LIBS+=3D$(libs_softmmu) =20 # xen support diff --git a/configure b/configure index 6401762..c61d862 100755 --- a/configure +++ b/configure @@ -4303,10 +4303,6 @@ if test "$target_bigendian" =3D "yes" ; then fi if test "$target_softmmu" =3D "yes" ; then echo "CONFIG_SOFTMMU=3Dy" >> $config_target_mak - case "$target_arch2" in - i386|x86_64) - echo "CONFIG_HAVE_CORE_DUMP=3Dy" >> $config_target_mak - esac fi if test "$target_user_only" =3D "yes" ; then echo "CONFIG_USER_ONLY=3Dy" >> $config_target_mak diff --git a/hmp-commands.hx b/hmp-commands.hx index 396691a..915b0d1 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -991,7 +991,6 @@ server will ask the spice/vnc client to automatically= reconnect using the new parameters (if specified) once the vm migration finished successfull= y. ETEXI =20 -#if defined(CONFIG_HAVE_CORE_DUMP) { .name =3D "dump-guest-memory", .args_type =3D "paging:-p,filename:F,begin:i?,length:i?", @@ -1015,7 +1014,6 @@ gdb. length: the memory size, in bytes. It's optional, and should be spec= ified with begin together. ETEXI -#endif =20 { .name =3D "snapshot_blkdev", diff --git a/stubs/dump.c b/stubs/dump.c index b3f42cb..43c9a3f 100644 --- a/stubs/dump.c +++ b/stubs/dump.c @@ -16,14 +16,6 @@ #include "qapi/qmp/qerror.h" #include "qmp-commands.h" =20 -/* we need this function in hmp.c */ -void qmp_dump_guest_memory(bool paging, const char *file, bool has_begin= , - int64_t begin, bool has_length, int64_t lengt= h, - Error **errp) -{ - error_set(errp, QERR_UNSUPPORTED); -} - int cpu_get_dump_info(ArchDumpInfo *info) { return -1; --=20 1.8.1.4