From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Umvfa-0008Ch-7g for qemu-devel@nongnu.org; Wed, 12 Jun 2013 20:45:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UmvfY-0005V6-4S for qemu-devel@nongnu.org; Wed, 12 Jun 2013 20:45:42 -0400 Received: from cantor2.suse.de ([195.135.220.15]:32929 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmvfX-0005Us-V0 for qemu-devel@nongnu.org; Wed, 12 Jun 2013 20:45:40 -0400 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Thu, 13 Jun 2013 02:45:19 +0200 Message-Id: <1371084329-814-8-git-send-email-afaerber@suse.de> In-Reply-To: <1371084329-814-1-git-send-email-afaerber@suse.de> References: <1371084329-814-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 07/17] monitor: Simplify do_inject_mce() with qemu_get_cpu() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Andreas=20F=C3=A4rber?= , Luiz Capitulino Avoids an open-coded CPU loop. Reviewed-by: liguang Reviewed-by: Luiz Capitulino Signed-off-by: Andreas F=C3=A4rber --- monitor.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/monitor.c b/monitor.c index 017411f..70ae8f5 100644 --- a/monitor.c +++ b/monitor.c @@ -2013,7 +2013,6 @@ static void do_acl_remove(Monitor *mon, const QDict= *qdict) static void do_inject_mce(Monitor *mon, const QDict *qdict) { X86CPU *cpu; - CPUX86State *cenv; CPUState *cs; int cpu_index =3D qdict_get_int(qdict, "cpu_index"); int bank =3D qdict_get_int(qdict, "bank"); @@ -2026,14 +2025,11 @@ static void do_inject_mce(Monitor *mon, const QDi= ct *qdict) if (qdict_get_try_bool(qdict, "broadcast", 0)) { flags |=3D MCE_INJECT_BROADCAST; } - for (cenv =3D first_cpu; cenv !=3D NULL; cenv =3D cenv->next_cpu) { - cpu =3D x86_env_get_cpu(cenv); - cs =3D CPU(cpu); - if (cs->cpu_index =3D=3D cpu_index) { - cpu_x86_inject_mce(mon, cpu, bank, status, mcg_status, addr,= misc, - flags); - break; - } + cs =3D qemu_get_cpu(cpu_index); + if (cs !=3D NULL) { + cpu =3D X86_CPU(cs); + cpu_x86_inject_mce(mon, cpu, bank, status, mcg_status, addr, mis= c, + flags); } } #endif --=20 1.8.1.4