From: Liu Ping Fan <qemulist@gmail.com>
To: qemu-devel@nongnu.org
Cc: mdroth <mdroth@linux.vnet.ibm.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH v2 4/6] net: force NetQue opaque to be NetClientState
Date: Thu, 13 Jun 2013 17:03:04 +0800 [thread overview]
Message-ID: <1371114186-8854-5-git-send-email-qemulist@gmail.com> (raw)
In-Reply-To: <1371114186-8854-1-git-send-email-qemulist@gmail.com>
From: Liu Ping Fan <pingfanl@linux.vnet.ibm.com>
qemu_net_client_setup() is the only user of qemu_new_net_queue(), which
will pass in NetClientState. By forcing it be a NetClientState, we
can ref/unref NetQueue's owner
Signed-off-by: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
---
include/net/queue.h | 2 +-
net/queue.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/net/queue.h b/include/net/queue.h
index fc02b33..ddb6d98 100644
--- a/include/net/queue.h
+++ b/include/net/queue.h
@@ -34,7 +34,7 @@ typedef void (NetPacketSent) (NetClientState *sender, ssize_t ret);
#define QEMU_NET_PACKET_FLAG_NONE 0
#define QEMU_NET_PACKET_FLAG_RAW (1<<0)
-NetQueue *qemu_new_net_queue(void *opaque);
+NetQueue *qemu_new_net_queue(NetClientState *opaque);
void qemu_del_net_queue(NetQueue *queue);
diff --git a/net/queue.c b/net/queue.c
index 7d6c52e..58222b0 100644
--- a/net/queue.c
+++ b/net/queue.c
@@ -49,7 +49,7 @@ struct NetPacket {
};
struct NetQueue {
- void *opaque;
+ NetClientState *opaque;
uint32_t nq_maxlen;
uint32_t nq_count;
@@ -59,7 +59,7 @@ struct NetQueue {
unsigned delivering : 1;
};
-NetQueue *qemu_new_net_queue(void *opaque)
+NetQueue *qemu_new_net_queue(NetClientState *opaque)
{
NetQueue *queue;
--
1.8.1.4
next prev parent reply other threads:[~2013-06-13 9:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 9:03 [Qemu-devel] [PATCH v2 0/6] port network layer onto glib Liu Ping Fan
2013-06-13 9:03 ` [Qemu-devel] [PATCH v2 1/6] net: introduce lock to protect NetQueue Liu Ping Fan
2013-06-13 9:03 ` [Qemu-devel] [PATCH v2 2/6] net: introduce lock to protect NetClientState's peer's access Liu Ping Fan
2013-06-18 12:25 ` Stefan Hajnoczi
2013-06-20 6:30 ` liu ping fan
2013-06-20 7:46 ` Stefan Hajnoczi
2013-06-20 9:17 ` liu ping fan
2013-06-13 9:03 ` [Qemu-devel] [PATCH v2 3/6] net: make netclient re-entrant with refcnt Liu Ping Fan
2013-06-18 12:41 ` Stefan Hajnoczi
2013-06-20 9:14 ` liu ping fan
2013-07-01 11:50 ` Stefan Hajnoczi
2013-07-03 3:41 ` liu ping fan
2013-07-03 7:49 ` Stefan Hajnoczi
2013-07-03 7:54 ` liu ping fan
2013-07-03 12:01 ` Stefan Hajnoczi
2013-06-13 9:03 ` Liu Ping Fan [this message]
2013-06-18 12:47 ` [Qemu-devel] [PATCH v2 4/6] net: force NetQue opaque to be NetClientState Stefan Hajnoczi
2013-06-20 6:30 ` liu ping fan
2013-06-13 9:03 ` [Qemu-devel] [PATCH v2 5/6] net: defer nested call to BH Liu Ping Fan
2013-06-18 12:57 ` Stefan Hajnoczi
2013-06-20 6:30 ` liu ping fan
2013-06-20 7:48 ` Stefan Hajnoczi
2013-07-03 6:20 ` Paolo Bonzini
2013-06-13 9:03 ` [Qemu-devel] [PATCH v2 6/6] net: hub use lock to protect ports list Liu Ping Fan
2013-06-18 13:07 ` [Qemu-devel] [PATCH v2 0/6] port network layer onto glib Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371114186-8854-5-git-send-email-qemulist@gmail.com \
--to=qemulist@gmail.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).