From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Ping Fan Liu <pingfank@linux.vnet.ibm.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [RFC 10/13] block: disable I/O throttling outside main loop
Date: Fri, 14 Jun 2013 11:48:30 +0200 [thread overview]
Message-ID: <1371203313-26490-11-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1371203313-26490-1-git-send-email-stefanha@redhat.com>
Timers only work in the main loop. This means threads running their own
AioContext cannot use I/O throttling for now.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
block.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/block.c b/block.c
index d986fc8..2d7a0f8 100644
--- a/block.c
+++ b/block.c
@@ -169,6 +169,11 @@ static void bdrv_io_limits_intercept(BlockDriverState *bs,
{
int64_t wait_time = -1;
+ /* Timers currently only work in the main loop */
+ if (*get_thread_aio_context() != qemu_get_aio_context()) {
+ return;
+ }
+
if (!qemu_co_queue_empty(&bs->throttled_reqs)) {
qemu_co_queue_wait(&bs->throttled_reqs);
}
--
1.8.1.4
next prev parent reply other threads:[~2013-06-14 9:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 9:48 [Qemu-devel] [RFC 00/13] dataplane: use block layer Stefan Hajnoczi
2013-06-14 9:48 ` [Qemu-devel] [RFC 01/13] block: fix bdrv_flush() ordering in bdrv_close() Stefan Hajnoczi
2013-06-14 9:48 ` [Qemu-devel] [RFC 02/13] dataplane: sync virtio.c and vring.c virtqueue state Stefan Hajnoczi
2013-06-14 9:48 ` [Qemu-devel] [RFC 03/13] block: add BlockDevOps->drain_threads_cb() Stefan Hajnoczi
2013-06-14 9:48 ` [Qemu-devel] [RFC 04/13] virtio-blk: implement BlockDevOps->drain_threads_cb() Stefan Hajnoczi
2013-06-14 14:23 ` Paolo Bonzini
2013-06-14 9:48 ` [Qemu-devel] [RFC 05/13] exec: do not use qemu/tls.h Stefan Hajnoczi
2013-06-14 9:48 ` [Qemu-devel] [RFC 06/13] qemu-thread: add TLS wrappers Stefan Hajnoczi
2013-06-20 7:26 ` Fam Zheng
2013-06-20 8:50 ` Paolo Bonzini
2013-06-20 12:54 ` Stefan Hajnoczi
2013-06-14 9:48 ` [Qemu-devel] [RFC 07/13] block: add thread_aio_context TLS variable Stefan Hajnoczi
2013-06-14 9:48 ` [Qemu-devel] [RFC 08/13] block: drop bdrv_get_aio_context() Stefan Hajnoczi
2013-06-14 14:12 ` Paolo Bonzini
2013-06-17 14:57 ` Stefan Hajnoczi
2013-06-17 15:03 ` Paolo Bonzini
2013-06-18 9:29 ` Stefan Hajnoczi
2013-06-14 9:48 ` [Qemu-devel] [RFC 09/13] main-loop: use thread-local AioContext Stefan Hajnoczi
2013-06-14 9:48 ` Stefan Hajnoczi [this message]
2013-06-14 9:48 ` [Qemu-devel] [RFC 11/13] dataplane: use block layer for I/O Stefan Hajnoczi
2013-06-14 9:48 ` [Qemu-devel] [RFC 12/13] dataplane: drop ioq Linux AIO request queue Stefan Hajnoczi
2013-06-14 9:48 ` [Qemu-devel] [RFC 13/13] block: drop raw_get_aio_fd() Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371203313-26490-11-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pingfank@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).