From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnQdV-0002pw-EG for qemu-devel@nongnu.org; Fri, 14 Jun 2013 05:49:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UnQdS-0000qu-Iv for qemu-devel@nongnu.org; Fri, 14 Jun 2013 05:49:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11091) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnQdS-0000qh-9y for qemu-devel@nongnu.org; Fri, 14 Jun 2013 05:49:34 -0400 From: Stefan Hajnoczi Date: Fri, 14 Jun 2013 11:48:33 +0200 Message-Id: <1371203313-26490-14-git-send-email-stefanha@redhat.com> In-Reply-To: <1371203313-26490-1-git-send-email-stefanha@redhat.com> References: <1371203313-26490-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [RFC 13/13] block: drop raw_get_aio_fd() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , Anthony Liguori , Ping Fan Liu , Stefan Hajnoczi virtio-blk data plane only worked with -drive format=raw,aio=native. It used raw_get_aio_fd() to fetch the file descriptor from raw-posix. This was a layering violation and is no longer necessary now that virtio-blk data plane uses the QEMU block layer. Signed-off-by: Stefan Hajnoczi --- block/raw-posix.c | 34 ---------------------------------- include/block/block.h | 8 -------- 2 files changed, 42 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index 821c19f..c4d0000 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -1910,40 +1910,6 @@ static BlockDriver bdrv_host_cdrom = { }; #endif /* __FreeBSD__ */ -#ifdef CONFIG_LINUX_AIO -/** - * Return the file descriptor for Linux AIO - * - * This function is a layering violation and should be removed when it becomes - * possible to call the block layer outside the global mutex. It allows the - * caller to hijack the file descriptor so I/O can be performed outside the - * block layer. - */ -int raw_get_aio_fd(BlockDriverState *bs) -{ - BDRVRawState *s; - - if (!bs->drv) { - return -ENOMEDIUM; - } - - if (bs->drv == bdrv_find_format("raw")) { - bs = bs->file; - } - - /* raw-posix has several protocols so just check for raw_aio_readv */ - if (bs->drv->bdrv_aio_readv != raw_aio_readv) { - return -ENOTSUP; - } - - s = bs->opaque; - if (!s->use_aio) { - return -ENOTSUP; - } - return s->fd; -} -#endif /* CONFIG_LINUX_AIO */ - static void bdrv_file_init(void) { /* diff --git a/include/block/block.h b/include/block/block.h index 85147bb..4273458 100644 --- a/include/block/block.h +++ b/include/block/block.h @@ -364,14 +364,6 @@ void bdrv_disable_copy_on_read(BlockDriverState *bs); void bdrv_set_in_use(BlockDriverState *bs, int in_use); int bdrv_in_use(BlockDriverState *bs); -#ifdef CONFIG_LINUX_AIO -int raw_get_aio_fd(BlockDriverState *bs); -#else -static inline int raw_get_aio_fd(BlockDriverState *bs) -{ - return -ENOTSUP; -} -#endif enum BlockAcctType { BDRV_ACCT_READ, -- 1.8.1.4