qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Ping Fan Liu <pingfank@linux.vnet.ibm.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [RFC 04/13] virtio-blk: implement BlockDevOps->drain_threads_cb()
Date: Fri, 14 Jun 2013 11:48:24 +0200	[thread overview]
Message-ID: <1371203313-26490-5-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1371203313-26490-1-git-send-email-stefanha@redhat.com>

Drain and stop the dataplane thread when bdrv_drain_all() is called.
Note that the thread will be restarted in virtio_blk_handle_output() the
next time the guest kicks the virtqueue.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 hw/block/virtio-blk.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index cf12469..f9c2b79 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -618,8 +618,20 @@ static void virtio_blk_resize(void *opaque)
     virtio_notify_config(vdev);
 }
 
+static void virtio_blk_drain_threads(void *opaque)
+{
+#ifdef CONFIG_VIRTIO_BLK_DATA_PLANE
+    VirtIOBlock *s = VIRTIO_BLK(opaque);
+
+    if (s->dataplane) {
+        virtio_blk_data_plane_stop(s->dataplane);
+    }
+#endif
+}
+
 static const BlockDevOps virtio_block_ops = {
     .resize_cb = virtio_blk_resize,
+    .drain_threads_cb = virtio_blk_drain_threads,
 };
 
 void virtio_blk_set_conf(DeviceState *dev, VirtIOBlkConf *blk)
-- 
1.8.1.4

  parent reply	other threads:[~2013-06-14  9:49 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14  9:48 [Qemu-devel] [RFC 00/13] dataplane: use block layer Stefan Hajnoczi
2013-06-14  9:48 ` [Qemu-devel] [RFC 01/13] block: fix bdrv_flush() ordering in bdrv_close() Stefan Hajnoczi
2013-06-14  9:48 ` [Qemu-devel] [RFC 02/13] dataplane: sync virtio.c and vring.c virtqueue state Stefan Hajnoczi
2013-06-14  9:48 ` [Qemu-devel] [RFC 03/13] block: add BlockDevOps->drain_threads_cb() Stefan Hajnoczi
2013-06-14  9:48 ` Stefan Hajnoczi [this message]
2013-06-14 14:23   ` [Qemu-devel] [RFC 04/13] virtio-blk: implement BlockDevOps->drain_threads_cb() Paolo Bonzini
2013-06-14  9:48 ` [Qemu-devel] [RFC 05/13] exec: do not use qemu/tls.h Stefan Hajnoczi
2013-06-14  9:48 ` [Qemu-devel] [RFC 06/13] qemu-thread: add TLS wrappers Stefan Hajnoczi
2013-06-20  7:26   ` Fam Zheng
2013-06-20  8:50     ` Paolo Bonzini
2013-06-20 12:54       ` Stefan Hajnoczi
2013-06-14  9:48 ` [Qemu-devel] [RFC 07/13] block: add thread_aio_context TLS variable Stefan Hajnoczi
2013-06-14  9:48 ` [Qemu-devel] [RFC 08/13] block: drop bdrv_get_aio_context() Stefan Hajnoczi
2013-06-14 14:12   ` Paolo Bonzini
2013-06-17 14:57     ` Stefan Hajnoczi
2013-06-17 15:03       ` Paolo Bonzini
2013-06-18  9:29         ` Stefan Hajnoczi
2013-06-14  9:48 ` [Qemu-devel] [RFC 09/13] main-loop: use thread-local AioContext Stefan Hajnoczi
2013-06-14  9:48 ` [Qemu-devel] [RFC 10/13] block: disable I/O throttling outside main loop Stefan Hajnoczi
2013-06-14  9:48 ` [Qemu-devel] [RFC 11/13] dataplane: use block layer for I/O Stefan Hajnoczi
2013-06-14  9:48 ` [Qemu-devel] [RFC 12/13] dataplane: drop ioq Linux AIO request queue Stefan Hajnoczi
2013-06-14  9:48 ` [Qemu-devel] [RFC 13/13] block: drop raw_get_aio_fd() Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371203313-26490-5-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=pingfank@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).