qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: mrhines@linux.vnet.ibm.com
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, quintela@redhat.com, knoel@redhat.com,
	owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com,
	gokul@us.ibm.com, pbonzini@redhat.com, chegu_vinod@hp.com
Subject: [Qemu-devel] [PATCH v9 07/14] rdma: introduce ram_handle_compressed()
Date: Fri, 14 Jun 2013 16:35:46 -0400	[thread overview]
Message-ID: <1371242153-11262-8-git-send-email-mrhines@linux.vnet.ibm.com> (raw)
In-Reply-To: <1371242153-11262-1-git-send-email-mrhines@linux.vnet.ibm.com>

From: "Michael R. Hines" <mrhines@us.ibm.com>

This gives RDMA shared access to madvise() on the destination side
when an entire chunk is found to be zero.

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Michael R. Hines <mrhines@us.ibm.com>
---
 arch_init.c                   |   24 ++++++++++++++++--------
 include/migration/migration.h |    2 ++
 2 files changed, 18 insertions(+), 8 deletions(-)

diff --git a/arch_init.c b/arch_init.c
index 819ca5a..2f1fdd3 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -782,6 +782,21 @@ static inline void *host_from_stream_offset(QEMUFile *f,
     return NULL;
 }
 
+/*
+ * If a page (or a whole RDMA chunk) has been
+ * determined to be zero, then zap it.
+ */
+void ram_handle_compressed(void *host, uint8_t ch, uint64_t size)
+{
+    memset(host, ch, TARGET_PAGE_SIZE);
+#ifndef _WIN32
+    if (ch == 0 && (!kvm_enabled() || kvm_has_sync_mmu()) &&
+                            getpagesize() <= TARGET_PAGE_SIZE) {
+        qemu_madvise(host, size, QEMU_MADV_DONTNEED);
+    }
+#endif
+}
+
 static int ram_load(QEMUFile *f, void *opaque, int version_id)
 {
     ram_addr_t addr;
@@ -849,14 +864,7 @@ static int ram_load(QEMUFile *f, void *opaque, int version_id)
             }
 
             ch = qemu_get_byte(f);
-            memset(host, ch, TARGET_PAGE_SIZE);
-#ifndef _WIN32
-            if (ch == 0 &&
-                (!kvm_enabled() || kvm_has_sync_mmu()) &&
-                getpagesize() <= TARGET_PAGE_SIZE) {
-                qemu_madvise(host, TARGET_PAGE_SIZE, QEMU_MADV_DONTNEED);
-            }
-#endif
+            ram_handle_compressed(host, ch, TARGET_PAGE_SIZE);
         } else if (flags & RAM_SAVE_FLAG_PAGE) {
             void *host;
 
diff --git a/include/migration/migration.h b/include/migration/migration.h
index 1eeaa40..110f4ad 100644
--- a/include/migration/migration.h
+++ b/include/migration/migration.h
@@ -108,6 +108,8 @@ uint64_t xbzrle_mig_pages_transferred(void);
 uint64_t xbzrle_mig_pages_overflow(void);
 uint64_t xbzrle_mig_pages_cache_miss(void);
 
+void ram_handle_compressed(void *host, uint8_t ch, uint64_t size);
+
 /**
  * @migrate_add_blocker - prevent migration from proceeding
  *
-- 
1.7.10.4

  parent reply	other threads:[~2013-06-14 20:36 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14 20:35 [Qemu-devel] [PATCH v9 00/14] rdma: migration support mrhines
2013-06-14 20:35 ` [Qemu-devel] [PATCH v9 01/14] rdma: add documentation mrhines
2013-06-14 20:35 ` [Qemu-devel] [PATCH v9 02/14] rdma: introduce qemu_update_position() mrhines
2013-06-14 20:35 ` [Qemu-devel] [PATCH v9 03/14] rdma: export yield_until_fd_readable() mrhines
2013-06-14 20:35 ` [Qemu-devel] [PATCH v9 04/14] rdma: export throughput w/ MigrationStats QMP mrhines
2013-06-15  9:09   ` Eric Blake
2013-06-16  4:04     ` Michael R. Hines
2013-06-14 20:35 ` [Qemu-devel] [PATCH v9 05/14] rdma: introduce qemu_file_mode_is_not_valid() mrhines
2013-06-14 20:35 ` [Qemu-devel] [PATCH v9 06/14] rdma: export qemu_fflush() mrhines
2013-06-14 20:35 ` mrhines [this message]
2013-06-14 20:35 ` [Qemu-devel] [PATCH v9 08/14] rdma: introduce qemu_ram_foreach_block() mrhines
2013-06-14 20:35 ` [Qemu-devel] [PATCH v9 09/14] rdma: new QEMUFileOps hooks mrhines
2013-06-14 20:35 ` [Qemu-devel] [PATCH v9 10/14] rdma: introduce capability x-rdma-pin-all mrhines
2013-06-15  9:05   ` Eric Blake
2013-06-16  4:04     ` Michael R. Hines
2013-06-14 20:35 ` [Qemu-devel] [PATCH v9 11/14] rdma: core logic mrhines
2013-06-14 20:35 ` [Qemu-devel] [PATCH v9 12/14] rdma: send pc.ram mrhines
2013-06-14 20:35 ` [Qemu-devel] [PATCH v9 13/14] rdma: fix mlock() freezes and accounting mrhines
2013-06-14 20:35 ` [Qemu-devel] [PATCH v9 14/14] rdma: add pin-all accounting timestamp to QMP statistics mrhines
2013-06-15  9:06   ` Eric Blake
2013-06-15 17:32     ` Paolo Bonzini
2013-06-16  4:06       ` Michael R. Hines
2013-06-16  4:05     ` Michael R. Hines
2013-06-16 18:37   ` Chegu Vinod
2013-06-18 20:17     ` Michael R. Hines
2013-06-15 22:51 ` [Qemu-devel] [PATCH v9 00/14] rdma: migration support Chegu Vinod
2013-06-16  4:07   ` Michael R. Hines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371242153-11262-8-git-send-email-mrhines@linux.vnet.ibm.com \
    --to=mrhines@linux.vnet.ibm.com \
    --cc=abali@us.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=chegu_vinod@hp.com \
    --cc=gokul@us.ibm.com \
    --cc=knoel@redhat.com \
    --cc=mrhines@us.ibm.com \
    --cc=owasserm@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).