qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Hu Tao <hutao@cn.fujitsu.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Markus Armbruster <armbru@redhat.com>
Subject: [Qemu-devel] [PATCH 2/2] pvpanic: fix fwcfg for big endian hosts
Date: Sun, 16 Jun 2013 23:59:49 +0300	[thread overview]
Message-ID: <1371416189-29563-2-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1371416189-29563-1-git-send-email-mst@redhat.com>

Convert port number to little endian when
exposing it in fw cfg.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/misc/pvpanic.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c
index 9ed9897..151eefe 100644
--- a/hw/misc/pvpanic.c
+++ b/hw/misc/pvpanic.c
@@ -106,12 +106,13 @@ int pvpanic_init(ISABus *bus)
     ISADevice *dev = isa_create_simple(bus, TYPE_ISA_PVPANIC_DEVICE);
     PVPanicState *s = ISA_PVPANIC_DEVICE(dev);
     FWCfgState *fw_cfg = fw_cfg_find();
+    uint16_t *pvpanic_port = g_malloc(sizeof(*pvpanic_port));
+    *pvpanic_port = cpu_to_le16(s->ioport);
 
     assert(fw_cfg);
 
-    fw_cfg_add_file(fw_cfg, "etc/pvpanic-port",
-                    g_memdup(&s->ioport, sizeof(s->ioport)),
-                    sizeof(s->ioport));
+    fw_cfg_add_file(fw_cfg, "etc/pvpanic-port", pvpanic_port,
+                    sizeof(*pvpanic_port));
 
     return 0;
 }
-- 
MST

  reply	other threads:[~2013-06-16 21:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-16 20:59 [Qemu-devel] [PATCH 1/2] pvpanic: initialization cleanup Michael S. Tsirkin
2013-06-16 20:59 ` Michael S. Tsirkin [this message]
2013-06-17  7:56 ` Laszlo Ersek
2013-06-17  9:19   ` Michael S. Tsirkin
2013-06-17  9:35     ` Laszlo Ersek
2013-06-17  9:57       ` Michael S. Tsirkin
2013-06-17 10:07         ` Laszlo Ersek
2013-06-19 13:39           ` Stefano Stabellini
2013-06-19 13:58             ` Laszlo Ersek
2013-06-19 13:30         ` Stefano Stabellini
2013-06-19 13:29       ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371416189-29563-2-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=hutao@cn.fujitsu.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).