qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com
Subject: [Qemu-devel] [PULL 8/9] block: bdrv_reopen_prepare(): don't use QERR_OPEN_FILE_FAILED
Date: Mon, 17 Jun 2013 11:57:10 -0400	[thread overview]
Message-ID: <1371484631-29510-9-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1371484631-29510-1-git-send-email-lcapitulino@redhat.com>

The call to drv->bdrv_reopen_prepare() can fail due to reasons
other than an open failure. Unfortunately, we can't use errno
nor -ret, cause they are not always set.

Stick to a generic error message then.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
---
 block.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block.c b/block.c
index 79ad33d..b88ad2f 100644
--- a/block.c
+++ b/block.c
@@ -1291,8 +1291,8 @@ int bdrv_reopen_prepare(BDRVReopenState *reopen_state, BlockReopenQueue *queue,
             if (local_err != NULL) {
                 error_propagate(errp, local_err);
             } else {
-                error_set(errp, QERR_OPEN_FILE_FAILED,
-                          reopen_state->bs->filename);
+                error_setg(errp, "failed while preparing to reopen image '%s'",
+                           reopen_state->bs->filename);
             }
             goto error;
         }
-- 
1.8.1.4

  parent reply	other threads:[~2013-06-17 16:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-17 15:57 [Qemu-devel] [PULL 0/9] QMP queue Luiz Capitulino
2013-06-17 15:57 ` [Qemu-devel] [PULL 1/9] error: add error_setg_file_open() helper Luiz Capitulino
2013-06-17 15:57 ` [Qemu-devel] [PULL 2/9] rng-random: use error_setg_file_open() Luiz Capitulino
2013-06-17 15:57 ` [Qemu-devel] [PULL 3/9] block: mirror_complete(): " Luiz Capitulino
2013-06-17 15:57 ` [Qemu-devel] [PULL 4/9] blockdev: " Luiz Capitulino
2013-06-17 15:57 ` [Qemu-devel] [PULL 5/9] cpus: " Luiz Capitulino
2013-06-17 15:57 ` [Qemu-devel] [PULL 6/9] dump: qmp_dump_guest_memory(): " Luiz Capitulino
2013-06-17 15:57 ` [Qemu-devel] [PULL 7/9] savevm: qmp_xen_save_devices_state(): " Luiz Capitulino
2013-06-17 15:57 ` Luiz Capitulino [this message]
2013-06-17 15:57 ` [Qemu-devel] [PULL 9/9] qerror: drop QERR_OPEN_FILE_FAILED macro Luiz Capitulino
2013-06-17 21:17 ` [Qemu-devel] [PULL 0/9] QMP queue Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371484631-29510-9-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).