qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, Anton Blanchard <anton@samba.org>,
	qemu-stable@nongnu.org
Subject: [Qemu-devel] [PULL 4/4] tcg-ppc64: rotr_i32 rotates wrong amount
Date: Mon, 17 Jun 2013 10:45:29 -0700	[thread overview]
Message-ID: <1371491129-30246-5-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1371491129-30246-1-git-send-email-rth@twiddle.net>

From: Anton Blanchard <anton@samba.org>

rotr_i32 calculates the amount to left shift and puts it into a
temporary, but then doesn't use it when doing the shift.

Cc: qemu-stable@nongnu.org
Signed-off-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 tcg/ppc64/tcg-target.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c
index 5cdff36..606b73d 100644
--- a/tcg/ppc64/tcg-target.c
+++ b/tcg/ppc64/tcg-target.c
@@ -1662,7 +1662,7 @@ static void tcg_out_op (TCGContext *s, TCGOpcode opc, const TCGArg *args,
             tcg_out_rlw(s, RLWINM, args[0], args[1], 32 - args[2], 0, 31);
         } else {
             tcg_out32(s, SUBFIC | TAI(0, args[2], 32));
-            tcg_out32(s, RLWNM | SAB(args[1], args[0], args[2])
+            tcg_out32(s, RLWNM | SAB(args[1], args[0], 0)
                          | MB(0) | ME(31));
         }
         break;
-- 
1.8.1.4

  parent reply	other threads:[~2013-06-17 17:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-17 17:45 [Qemu-devel] [PULL 0/4] Fix ppc64 tcg issues Richard Henderson
2013-06-17 17:45 ` [Qemu-devel] [PULL 1/4] tcg-ppc64: Fix RLDCL opcode Richard Henderson
2013-06-17 17:45 ` [Qemu-devel] [PULL 2/4] tcg-ppc64: bswap64 rotates output 32 bits Richard Henderson
2013-06-17 17:45 ` [Qemu-devel] [PULL 3/4] tcg-ppc64: Fix add2_i64 Richard Henderson
2013-06-17 17:45 ` Richard Henderson [this message]
2013-06-17 21:17 ` [Qemu-devel] [PULL 0/4] Fix ppc64 tcg issues Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371491129-30246-5-git-send-email-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=aliguori@us.ibm.com \
    --cc=anton@samba.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).