From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UodVL-0006sA-De for qemu-devel@nongnu.org; Mon, 17 Jun 2013 13:46:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UodVI-0003vq-JQ for qemu-devel@nongnu.org; Mon, 17 Jun 2013 13:46:11 -0400 Sender: Richard Henderson From: Richard Henderson Date: Mon, 17 Jun 2013 10:45:29 -0700 Message-Id: <1371491129-30246-5-git-send-email-rth@twiddle.net> In-Reply-To: <1371491129-30246-1-git-send-email-rth@twiddle.net> References: <1371491129-30246-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PULL 4/4] tcg-ppc64: rotr_i32 rotates wrong amount List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, Anton Blanchard , qemu-stable@nongnu.org From: Anton Blanchard rotr_i32 calculates the amount to left shift and puts it into a temporary, but then doesn't use it when doing the shift. Cc: qemu-stable@nongnu.org Signed-off-by: Anton Blanchard Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 5cdff36..606b73d 100644 --- a/tcg/ppc64/tcg-target.c +++ b/tcg/ppc64/tcg-target.c @@ -1662,7 +1662,7 @@ static void tcg_out_op (TCGContext *s, TCGOpcode opc, const TCGArg *args, tcg_out_rlw(s, RLWINM, args[0], args[1], 32 - args[2], 0, 31); } else { tcg_out32(s, SUBFIC | TAI(0, args[2], 32)); - tcg_out32(s, RLWNM | SAB(args[1], args[0], args[2]) + tcg_out32(s, RLWNM | SAB(args[1], args[0], 0) | MB(0) | ME(31)); } break; -- 1.8.1.4