From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH 12/17] ide: Convert FLUSH CACHE to ide_cmd_table handler
Date: Tue, 18 Jun 2013 10:26:06 +0200 [thread overview]
Message-ID: <1371543971-23241-13-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1371543971-23241-1-git-send-email-kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
hw/ide/core.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index 8789758..83e86aa 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -1184,6 +1184,12 @@ static bool cmd_write_dma(IDEState *s, uint8_t cmd)
return false;
}
+static bool cmd_flush_cache(IDEState *s, uint8_t cmd)
+{
+ ide_flush_cache(s);
+ return false;
+}
+
static bool cmd_read_native_max(IDEState *s, uint8_t cmd)
{
bool lba48 = (cmd == WIN_READ_NATIVE_MAX_EXT);
@@ -1345,8 +1351,8 @@ static const struct {
[WIN_SETIDLE1] = { cmd_nop, ALL_OK },
[WIN_CHECKPOWERMODE1] = { cmd_check_power_mode, ALL_OK | SET_DSC },
[WIN_SLEEPNOW1] = { cmd_nop, ALL_OK },
- [WIN_FLUSH_CACHE] = { NULL, ALL_OK },
- [WIN_FLUSH_CACHE_EXT] = { NULL, HD_CFA_OK },
+ [WIN_FLUSH_CACHE] = { cmd_flush_cache, ALL_OK },
+ [WIN_FLUSH_CACHE_EXT] = { cmd_flush_cache, HD_CFA_OK },
[WIN_IDENTIFY] = { cmd_identify, ALL_OK },
[WIN_SETFEATURES] = { cmd_set_features, ALL_OK | SET_DSC },
[IBM_SENSE_CONDITION] = { NULL, CFA_OK },
@@ -1403,10 +1409,6 @@ void ide_exec_cmd(IDEBus *bus, uint32_t val)
}
switch(val) {
- case WIN_FLUSH_CACHE:
- case WIN_FLUSH_CACHE_EXT:
- ide_flush_cache(s);
- break;
case WIN_SEEK:
/* XXX: Check that seek is within bounds */
s->status = READY_STAT | SEEK_STAT;
--
1.8.1.4
next prev parent reply other threads:[~2013-06-18 8:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 8:25 [Qemu-devel] [PATCH 00/17] ide: Use ide_cmd_table function pointers for command execution Kevin Wolf
2013-06-18 8:25 ` [Qemu-devel] [PATCH 01/17] ide: Add handler to ide_cmd_table Kevin Wolf
2013-06-19 11:45 ` Stefan Hajnoczi
2013-06-18 8:25 ` [Qemu-devel] [PATCH 02/17] ide: Convert WIN_DSM to ide_cmd_table handler Kevin Wolf
2013-06-18 8:25 ` [Qemu-devel] [PATCH 03/17] ide: Convert WIN_IDENTIFY " Kevin Wolf
2013-06-18 8:25 ` [Qemu-devel] [PATCH 04/17] ide: Convert cmd_nop commands " Kevin Wolf
2013-06-18 8:25 ` [Qemu-devel] [PATCH 05/17] ide: Convert verify " Kevin Wolf
2013-06-18 8:26 ` [Qemu-devel] [PATCH 06/17] ide: Convert read/write multiple " Kevin Wolf
2013-06-18 8:26 ` [Qemu-devel] [PATCH 07/17] ide: Convert PIO read/write " Kevin Wolf
2013-06-18 8:26 ` [Qemu-devel] [PATCH 08/17] ide: Convert DMA " Kevin Wolf
2013-06-18 8:26 ` [Qemu-devel] [PATCH 09/17] ide: Convert READ NATIVE MAX ADDRESS " Kevin Wolf
2013-06-18 8:26 ` [Qemu-devel] [PATCH 10/17] ide: Convert CHECK POWER MDOE " Kevin Wolf
2013-06-18 8:26 ` [Qemu-devel] [PATCH 11/17] ide: Convert SET FEATURES " Kevin Wolf
2013-06-18 8:26 ` Kevin Wolf [this message]
2013-06-18 8:26 ` [Qemu-devel] [PATCH 13/17] ide: Convert SEEK " Kevin Wolf
2013-06-18 8:26 ` [Qemu-devel] [PATCH 14/17] ide: Convert ATAPI commands " Kevin Wolf
2013-06-18 8:26 ` [Qemu-devel] [PATCH 15/17] ide: Convert CF-ATA " Kevin Wolf
2013-06-18 8:26 ` [Qemu-devel] [PATCH 16/17] ide: Convert SMART " Kevin Wolf
2013-06-18 8:26 ` [Qemu-devel] [PATCH 17/17] ide: Clean up ide_exec_cmd() Kevin Wolf
2013-06-19 12:28 ` [Qemu-devel] [PATCH 00/17] ide: Use ide_cmd_table function pointers for command execution Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371543971-23241-13-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).