From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpJIL-0003IL-CU for qemu-devel@nongnu.org; Wed, 19 Jun 2013 10:23:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UpJIK-0004aB-Aa for qemu-devel@nongnu.org; Wed, 19 Jun 2013 10:23:33 -0400 Received: from mail-ee0-x234.google.com ([2a00:1450:4013:c00::234]:35578) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpJIK-0004a0-4N for qemu-devel@nongnu.org; Wed, 19 Jun 2013 10:23:32 -0400 Received: by mail-ee0-f52.google.com with SMTP id c50so3301935eek.11 for ; Wed, 19 Jun 2013 07:23:30 -0700 (PDT) From: edgar.iglesias@gmail.com Date: Wed, 19 Jun 2013 16:20:28 +0200 Message-Id: <1371651629-31262-1-git-send-email-edgar.iglesias@gmail.com> Subject: [Qemu-devel] [PATCH v2] cadence_uart: Handle backend tx errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.crosthwaite@xilinx.com From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- v1 -> v2: Remove loop around qemu_chr_fe_write_all, it does not return short writes. hw/char/cadence_uart.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/char/cadence_uart.c b/hw/char/cadence_uart.c index c2a7834..205e125 100644 --- a/hw/char/cadence_uart.c +++ b/hw/char/cadence_uart.c @@ -297,9 +297,7 @@ static void uart_write_tx_fifo(UartState *s, const uint8_t *buf, int size) return; } - while (size) { - size -= qemu_chr_fe_write(s->chr, buf, size); - } + qemu_chr_fe_write_all(s->chr, buf, size); } static void uart_receive(void *opaque, const uint8_t *buf, int size) -- 1.7.10.4