From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpPCA-0000dO-Pz for qemu-devel@nongnu.org; Wed, 19 Jun 2013 16:41:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UpPC9-0004qx-AZ for qemu-devel@nongnu.org; Wed, 19 Jun 2013 16:41:34 -0400 Received: from e31.co.us.ibm.com ([32.97.110.149]:57928) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpPC9-0004qi-1P for qemu-devel@nongnu.org; Wed, 19 Jun 2013 16:41:33 -0400 Received: from /spool/local by e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 19 Jun 2013 14:41:32 -0600 From: Anthony Liguori Date: Wed, 19 Jun 2013 15:40:35 -0500 Message-Id: <1371674435-14973-13-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1371674435-14973-1-git-send-email-aliguori@us.ibm.com> References: <1371674435-14973-1-git-send-email-aliguori@us.ibm.com> Subject: [Qemu-devel] [PATCH 12/12] spapr-vty: remove unfixable FIXME List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori , Alexey Kardashevskiy , Alex Graf , qemu-ppc@nongnu.org, Paul Mackerras , Andreas Faerber Signed-off-by: Anthony Liguori --- hw/char/spapr_vty.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/char/spapr_vty.c b/hw/char/spapr_vty.c index aa56f10..6834fe2 100644 --- a/hw/char/spapr_vty.c +++ b/hw/char/spapr_vty.c @@ -65,7 +65,13 @@ static int spapr_vty_getchars(VIOsPAPRVTYDevice *dev, uint8_t *buf, int max) static void spapr_vty_putchars(VIOsPAPRVTYDevice *dev, const uint8_t *buf, int len) { - /* FIXME: should check the qemu_chr_fe_write() return value */ + /* There is no flow control with this interface so we can't really + * do anything if we are unable to write out data. So we ignore errors + * here and silently drop the data. + * + * Our only option would be buffering but the kernel already has a buffer + * so that would only delay the inevitable. + */ qemu_chr_fe_write(dev->chardev, buf, len); } -- 1.8.0