From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60546) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpfrG-00042z-6W for qemu-devel@nongnu.org; Thu, 20 Jun 2013 10:29:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Upfr7-0001Xe-9s for qemu-devel@nongnu.org; Thu, 20 Jun 2013 10:29:06 -0400 Received: from nodalink.pck.nerim.net ([62.212.105.220]:37611 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Upfr6-0001WV-Vp for qemu-devel@nongnu.org; Thu, 20 Jun 2013 10:28:57 -0400 From: =?UTF-8?q?Beno=C3=AEt=20Canet?= Date: Thu, 20 Jun 2013 16:26:28 +0200 Message-Id: <1371738392-9594-21-git-send-email-benoit@irqsave.net> In-Reply-To: <1371738392-9594-1-git-send-email-benoit@irqsave.net> References: <1371738392-9594-1-git-send-email-benoit@irqsave.net> Subject: [Qemu-devel] [RFC V8 20/24] qcow2: Serialize write requests when deduplication is activated. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, =?UTF-8?q?Beno=C3=AEt=20Canet?= , stefanha@redhat.com This fixes the sub cluster sized writes race conditions while waiting for a faster solution. Signed-off-by: Benoit Canet --- block/qcow2.c | 14 ++++++++++++++ block/qcow2.h | 1 + 2 files changed, 15 insertions(+) diff --git a/block/qcow2.c b/block/qcow2.c index 8eb63f1..11c115f 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -534,6 +534,7 @@ static int qcow2_open(BlockDriverState *bs, QDict *options, int flags) /* Initialise locks */ qemu_co_mutex_init(&s->lock); + qemu_co_mutex_init(&s->dedup_lock); /* Repair image if dirty */ if (!(flags & BDRV_O_CHECK) && !bs->read_only && @@ -841,6 +842,15 @@ static coroutine_fn int qcow2_co_writev(BlockDriverState *bs, s->cluster_cache_offset = -1; /* disable compressed cache */ + if (s->has_dedup) { + /* This mutex is used to serialize the write requests in the dedup case. + * The goal is to avoid that the dedup process concurrents requests to + * the same clusters and corrupt data. + * With qcow2_dedup_read_missing_and_concatenate that would not work. + */ + qemu_co_mutex_lock(&s->dedup_lock); + } + qemu_co_mutex_lock(&s->lock); if (s->has_dedup) { @@ -1018,6 +1028,10 @@ fail: l2meta = next; } + if (s->has_dedup) { + qemu_co_mutex_unlock(&s->dedup_lock); + } + qemu_iovec_destroy(&hd_qiov); qemu_vfree(cluster_data); qemu_vfree(dedup_cluster_data); diff --git a/block/qcow2.h b/block/qcow2.h index 6f85e03..3c6e685 100644 --- a/block/qcow2.h +++ b/block/qcow2.h @@ -364,6 +364,7 @@ typedef struct BDRVQcowState { Coroutine *load_filter_co; /* used to load incarnations filters */ CoMutex lock; + CoMutex dedup_lock; uint32_t crypt_method; /* current crypt method, 0 if no key yet */ uint32_t crypt_method_header; -- 1.7.10.4