From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37474) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Upg7Z-0007SI-Ni for qemu-devel@nongnu.org; Thu, 20 Jun 2013 10:46:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Upg7U-0007Jr-QX for qemu-devel@nongnu.org; Thu, 20 Jun 2013 10:45:57 -0400 Received: from mail-ea0-x231.google.com ([2a00:1450:4013:c01::231]:38364) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Upg7U-0007Jb-CH for qemu-devel@nongnu.org; Thu, 20 Jun 2013 10:45:52 -0400 Received: by mail-ea0-f177.google.com with SMTP id j14so3951252eak.8 for ; Thu, 20 Jun 2013 07:45:51 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Thu, 20 Jun 2013 16:44:52 +0200 Message-Id: <1371739493-10187-25-git-send-email-pbonzini@redhat.com> In-Reply-To: <1371739493-10187-1-git-send-email-pbonzini@redhat.com> References: <1371739493-10187-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 24/25] memory: as_update_topology_pass: Improve comments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Crosthwaite From: Peter Crosthwaite These comments were a little difficult to read. First one had incorrect parenthesis. The part about attributes changing is really applicable to the region being 'in both' rather than 'in new' Second comment has an obscure parenthetic about 'Logging may have changed'. Made clearer, as this if is supposed to handle the case where the memory region is unchanged (with the notable exception re logging). Signed-off-by: Peter Crosthwaite Signed-off-by: Paolo Bonzini --- memory.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/memory.c b/memory.c index 221b725..0e07d0f 100644 --- a/memory.c +++ b/memory.c @@ -719,7 +719,7 @@ static void address_space_update_topology_pass(AddressSpace *as, || int128_lt(frold->addr.start, frnew->addr.start) || (int128_eq(frold->addr.start, frnew->addr.start) && !flatrange_equal(frold, frnew)))) { - /* In old, but (not in new, or in new but attributes changed). */ + /* In old but not in new, or in both but attributes changed. */ if (!adding) { MEMORY_LISTENER_UPDATE_REGION(frold, as, Reverse, region_del); @@ -727,7 +727,7 @@ static void address_space_update_topology_pass(AddressSpace *as, ++iold; } else if (frold && frnew && flatrange_equal(frold, frnew)) { - /* In both (logging may have changed) */ + /* In both and unchanged (except logging may have changed) */ if (adding) { MEMORY_LISTENER_UPDATE_REGION(frnew, as, Forward, region_nop); -- 1.8.1.4