From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 13/13] qemu-socket: don't leak opts on error
Date: Fri, 21 Jun 2013 12:38:25 +0200 [thread overview]
Message-ID: <1371811105-730-14-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1371811105-730-1-git-send-email-kraxel@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
util/qemu-sockets.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index 7776016..29a3564 100644
--- a/util/qemu-sockets.c
+++ b/util/qemu-sockets.c
@@ -971,7 +971,7 @@ int socket_dgram(SocketAddress *remote, SocketAddress *local, Error **errp)
default:
error_setg(errp, "socket type unsupported for datagram");
- return -1;
+ fd = -1;
}
qemu_opts_del(opts);
return fd;
--
1.7.9.7
next prev parent reply other threads:[~2013-06-21 10:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 10:38 [Qemu-devel] [PATCH 00/13] A bunch of little socket + chardev fixes Gerd Hoffmann
2013-06-21 10:38 ` [Qemu-devel] [PATCH 01/13] qemu-socket: zero-initialize SocketAddress Gerd Hoffmann
2013-06-21 18:15 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-06-24 6:13 ` Gerd Hoffmann
2013-06-21 10:38 ` [Qemu-devel] [PATCH 02/13] qemu-socket: drop pointless allocation Gerd Hoffmann
2013-06-21 10:38 ` [Qemu-devel] [PATCH 03/13] qemu-socket: catch monitor_get_fd failures Gerd Hoffmann
2013-06-21 18:18 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-06-21 10:38 ` [Qemu-devel] [PATCH 04/13] qemu-char: check optional fields using has_* Gerd Hoffmann
2013-06-21 10:38 ` [Qemu-devel] [PATCH 05/13] qemu-char: use more specific error_setg_* variants Gerd Hoffmann
2013-06-21 10:38 ` [Qemu-devel] [PATCH 06/13] qemu-char: print notification to stderr Gerd Hoffmann
2013-06-21 10:38 ` [Qemu-devel] [PATCH 07/13] qemu-char: fix documentation for telnet+wait socket flags Gerd Hoffmann
2013-06-21 10:38 ` [Qemu-devel] [PATCH 08/13] qemu-char: don't leak opts on error Gerd Hoffmann
2013-06-21 10:38 ` [Qemu-devel] [PATCH 09/13] qemu-char: use ChardevBackendKind in in CharDriver Gerd Hoffmann
2013-06-21 18:36 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-06-21 10:38 ` [Qemu-devel] [PATCH 10/13] qemu-char: minor mux chardev fixes Gerd Hoffmann
2013-06-21 10:38 ` [Qemu-devel] [PATCH 11/13] qemu-char: add -chardev mux support Gerd Hoffmann
2013-06-21 10:38 ` [Qemu-devel] [PATCH 12/13] qemu-char: report udb backend errors Gerd Hoffmann
2013-06-21 10:38 ` Gerd Hoffmann [this message]
2013-06-21 18:47 ` [Qemu-devel] [Qemu-trivial] [PATCH 00/13] A bunch of little socket + chardev fixes Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371811105-730-14-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).