From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35352)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1Uq03h-0004wZ-EB
	for qemu-devel@nongnu.org; Fri, 21 Jun 2013 08:03:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1Uq03f-0002Ju-GR
	for qemu-devel@nongnu.org; Fri, 21 Jun 2013 08:03:17 -0400
Message-ID: <1371816181.3944.58.camel@pasglop>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Fri, 21 Jun 2013 22:03:01 +1000
In-Reply-To: <B63FF5F7-202D-488C-B91F-2578C58FB5FD@suse.de>
References: <1371806575-19347-1-git-send-email-aik@ozlabs.ru>
	<1371806575-19347-3-git-send-email-aik@ozlabs.ru>
	<B63FF5F7-202D-488C-B91F-2578C58FB5FD@suse.de>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/3] KVM: add kvm_arch_irqchip_add_msi_route
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org, Alex Williamson <alex.williamson@redhat.com>, qemu-ppc@nongnu.org, David Gibson <david@gibson.dropbear.id.au>

On Fri, 2013-06-21 at 12:33 +0200, Alexander Graf wrote:
> > +int kvm_arch_irqchip_add_msi_route(KVMState *s, MSIMessage msg)
> > +{
> > +    if (!kvm_msi_via_irqfd_allowed)
> > +        return -1;
> > +
> > +    msg.address -= spapr->msi_win_addr;
> > +    return (msg.address >> 2) + msg.data;
> 
> This breaks BookE.

It might be a bit more constructive to explain why and maybe propose a
solution... Alexey doesn't necessarily know the specifics of the BookE
stuff :-)

Cheers,
Ben.