From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uq3dR-0005pz-4Y for qemu-devel@nongnu.org; Fri, 21 Jun 2013 11:52:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uq3dQ-0005oV-3j for qemu-devel@nongnu.org; Fri, 21 Jun 2013 11:52:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7674) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uq3dP-0005oI-SV for qemu-devel@nongnu.org; Fri, 21 Jun 2013 11:52:24 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5LFqNRl013345 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 21 Jun 2013 11:52:23 -0400 From: Kevin Wolf Date: Fri, 21 Jun 2013 17:46:29 +0200 Message-Id: <1371829589-18045-4-git-send-email-kwolf@redhat.com> In-Reply-To: <1371829589-18045-1-git-send-email-kwolf@redhat.com> References: <1371829589-18045-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH v2 3/3] qapi-schema: Use BlockdevSnapshot type for blockdev-snapshot-sync List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, stefanha@redhat.com, lcapitulino@redhat.com We don't have to duplicate the definition any more now that we may refer to a type instead. Signed-off-by: Kevin Wolf --- qapi-schema.json | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index a80ee40..54fbeef 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -1652,16 +1652,7 @@ # # Generates a synchronous snapshot of a block device. # -# @device: the name of the device to generate the snapshot from. -# -# @snapshot-file: the target of the new image. If the file exists, or if it -# is a device, the snapshot will be created in the existing -# file/device. If does not exist, a new file will be created. -# -# @format: #optional the format of the snapshot image, default is 'qcow2'. -# -# @mode: #optional whether and how QEMU should create a new image, default is -# 'absolute-paths'. +# For the arguments, see the documentation of BlockdevSnapshot. # # Returns: nothing on success # If @device is not a valid block device, DeviceNotFound @@ -1669,8 +1660,7 @@ # Since 0.14.0 ## { 'command': 'blockdev-snapshot-sync', - 'data': { 'device': 'str', 'snapshot-file': 'str', '*format': 'str', - '*mode': 'NewImageMode'} } + 'data': 'BlockdevSnapshot' } ## # @human-monitor-command: -- 1.8.1.4