qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Aurelien Jarno <aurelien@aurel32.net>, Blue Swirl <blauwirbel@gmail.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>
Subject: [Qemu-devel] [PULL 1/8] target-arm: Allow special cpregs to have flags set
Date: Tue, 25 Jun 2013 18:33:05 +0100	[thread overview]
Message-ID: <1372181592-32170-2-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1372181592-32170-1-git-send-email-peter.maydell@linaro.org>

Relax the "is this a valid ARMCPRegInfo type value?" check to permit
"special" cpregs to have flags other than ARM_CP_SPECIAL set. At
the moment none of the other flags are relevant for special regs,
but the migration related flag we're about to introduce can apply
here too.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target-arm/cpu.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target-arm/cpu.h b/target-arm/cpu.h
index 5438444..737c00c 100644
--- a/target-arm/cpu.h
+++ b/target-arm/cpu.h
@@ -456,7 +456,7 @@ static inline bool cptype_valid(int cptype)
 {
     return ((cptype & ~ARM_CP_FLAG_MASK) == 0)
         || ((cptype & ARM_CP_SPECIAL) &&
-            (cptype <= ARM_LAST_SPECIAL));
+            ((cptype & ~ARM_CP_FLAG_MASK) <= ARM_LAST_SPECIAL));
 }
 
 /* Access rights:
-- 
1.7.9.5

  reply	other threads:[~2013-06-25 17:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-25 17:33 [Qemu-devel] [PULL 0/8] target-arm queue Peter Maydell
2013-06-25 17:33 ` Peter Maydell [this message]
2013-06-25 17:33 ` [Qemu-devel] [PULL 2/8] target-arm: Add raw_readfn and raw_writefn to ARMCPRegInfo Peter Maydell
2013-06-25 17:33 ` [Qemu-devel] [PULL 3/8] target-arm: mark up cpregs for no-migrate or raw access Peter Maydell
2013-06-25 17:33 ` [Qemu-devel] [PULL 4/8] target-arm: Convert TCG to using (index, value) list for cp migration Peter Maydell
2013-06-25 17:33 ` [Qemu-devel] [PULL 5/8] target-arm: Initialize cpreg list from KVM when using KVM Peter Maydell
2013-06-25 17:33 ` [Qemu-devel] [PULL 6/8] target-arm: Reinitialize all KVM VCPU registers on reset Peter Maydell
2013-06-25 17:33 ` [Qemu-devel] [PULL 7/8] target-arm: Use tuple list to sync cp regs with KVM Peter Maydell
2013-06-25 17:33 ` [Qemu-devel] [PULL 8/8] target-arm: Make LPAE feature imply V7MP Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372181592-32170-2-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=aliguori@us.ibm.com \
    --cc=aurelien@aurel32.net \
    --cc=blauwirbel@gmail.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).