From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, lilei@linux.vnet.ibm.com,
qemu-stable@nongnu.org, lcapitulino@redhat.com,
kraxel@redhat.com
Subject: [Qemu-devel] [PATCH 1/4] qemu-char: Fix ringbuf option size
Date: Thu, 27 Jun 2013 16:22:07 +0200 [thread overview]
Message-ID: <1372342930-28684-2-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1372342930-28684-1-git-send-email-armbru@redhat.com>
Any attempt to use it trips an "opt->desc->type == QEMU_OPT_NUMBER"
assertion. Broken in commit 1da48c65.
Cc: qemu-stable@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
qemu-char.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-char.c b/qemu-char.c
index 63972ae..63a9221 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -3108,7 +3108,7 @@ static void qemu_chr_parse_memory(QemuOpts *opts, ChardevBackend *backend,
backend->memory = g_new0(ChardevMemory, 1);
- val = qemu_opt_get_number(opts, "size", 0);
+ val = qemu_opt_get_size(opts, "size", 0);
if (val != 0) {
backend->memory->has_size = true;
backend->memory->size = val;
--
1.7.11.7
next prev parent reply other threads:[~2013-06-27 14:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 14:22 [Qemu-devel] [PATCH 0/4] qemu-char: ringbuf fixes Markus Armbruster
2013-06-27 14:22 ` Markus Armbruster [this message]
2013-06-27 23:17 ` [Qemu-devel] [PATCH 1/4] qemu-char: Fix ringbuf option size Eric Blake
2013-07-03 14:54 ` Luiz Capitulino
2013-06-27 14:22 ` [Qemu-devel] [PATCH 2/4] Revert "chardev: Make the name of memory device consistent" Markus Armbruster
2013-06-28 3:35 ` Lei Li
2013-06-28 7:15 ` Markus Armbruster
2013-06-27 14:22 ` [Qemu-devel] [PATCH 3/4] qemu-char: Register ring buffer driver with correct name "ringbuf" Markus Armbruster
2013-07-03 14:54 ` Luiz Capitulino
2013-07-04 6:30 ` Markus Armbruster
2013-06-27 14:22 ` [Qemu-devel] [PATCH 4/4] qapi: Rename ChardevBackend member "memory" to "ringbuf" Markus Armbruster
2013-06-28 13:37 ` Eric Blake
2013-06-28 17:19 ` Markus Armbruster
2013-07-01 3:08 ` Amos Kong
2013-07-01 8:10 ` Markus Armbruster
2013-07-01 9:00 ` Amos Kong
2013-07-01 9:28 ` Markus Armbruster
2013-07-01 11:17 ` Amos Kong
2013-07-01 16:08 ` Markus Armbruster
2013-07-01 12:52 ` Anthony Liguori
2013-07-03 14:55 ` [Qemu-devel] [PATCH 0/4] qemu-char: ringbuf fixes Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372342930-28684-2-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=lilei@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).