From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Juan Quintela <quintela@redhat.com>,
"Michael R. Hines" <mrhines@us.ibm.com>,
patches@linaro.org
Subject: [Qemu-devel] [PATCH] linux-user: Fix compilation failure
Date: Thu, 27 Jun 2013 20:53:38 +0100 [thread overview]
Message-ID: <1372362818-4740-1-git-send-email-peter.maydell@linaro.org> (raw)
Fix compilation failures for linux-user targets following recent
migration related commits bd2fa51fcd and 43487c67.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
Longer term we should probably try to disentangle migration
from user-mode emulators a bit better (eg hw.h should probably
not pull in any of the migration headers if CONFIG_USER_ONLY);
this is a minimal patch which fixes the compilation failures.
exec.c | 2 +-
include/hw/hw.h | 1 -
include/migration/vmstate.h | 2 ++
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/exec.c b/exec.c
index 2e6fc00..f99041b 100644
--- a/exec.c
+++ b/exec.c
@@ -2629,7 +2629,6 @@ bool cpu_physical_memory_is_io(hwaddr phys_addr)
return !(memory_region_is_ram(mr) ||
memory_region_is_romd(mr));
}
-#endif
void qemu_ram_foreach_block(RAMBlockIterFunc func, void *opaque)
{
@@ -2639,3 +2638,4 @@ void qemu_ram_foreach_block(RAMBlockIterFunc func, void *opaque)
func(block->host, block->offset, block->length, opaque);
}
}
+#endif
diff --git a/include/hw/hw.h b/include/hw/hw.h
index cc9f847..33bdb92 100644
--- a/include/hw/hw.h
+++ b/include/hw/hw.h
@@ -11,7 +11,6 @@
#include "exec/ioport.h"
#include "hw/irq.h"
#include "block/aio.h"
-#include "migration/qemu-file.h"
#include "migration/vmstate.h"
#include "qemu/log.h"
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index ebc4d09..1c31b5d 100644
--- a/include/migration/vmstate.h
+++ b/include/migration/vmstate.h
@@ -26,7 +26,9 @@
#ifndef QEMU_VMSTATE_H
#define QEMU_VMSTATE_H 1
+#ifndef CONFIG_USER_ONLY
#include <migration/qemu-file.h>
+#endif
typedef void SaveStateHandler(QEMUFile *f, void *opaque);
typedef int LoadStateHandler(QEMUFile *f, void *opaque, int version_id);
--
1.7.9.5
next reply other threads:[~2013-06-27 19:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 19:53 Peter Maydell [this message]
2013-06-27 20:03 ` [Qemu-devel] [PATCH] linux-user: Fix compilation failure Michael R. Hines
2013-07-01 13:14 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372362818-4740-1-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=aliguori@us.ibm.com \
--cc=mrhines@us.ibm.com \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).