From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsPYv-0006mJ-GW for qemu-devel@nongnu.org; Thu, 27 Jun 2013 23:41:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsPYu-0007b7-8K for qemu-devel@nongnu.org; Thu, 27 Jun 2013 23:41:29 -0400 Received: from e28smtp06.in.ibm.com ([122.248.162.6]:49765) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsPYt-0007Zl-Ka for qemu-devel@nongnu.org; Thu, 27 Jun 2013 23:41:28 -0400 Received: from /spool/local by e28smtp06.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 28 Jun 2013 09:03:52 +0530 Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id 507FDE0043 for ; Fri, 28 Jun 2013 09:10:58 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5S3fhON14680142 for ; Fri, 28 Jun 2013 09:11:43 +0530 Received: from d28av02.in.ibm.com (loopback [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5S3fLjP026860 for ; Fri, 28 Jun 2013 13:41:21 +1000 From: Wenchao Xia Date: Fri, 28 Jun 2013 11:39:31 +0800 Message-Id: <1372390771-11157-8-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1372390771-11157-1-git-send-email-xiawenc@linux.vnet.ibm.com> References: <1372390771-11157-1-git-send-email-xiawenc@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH V4 7/7] monitor: improve "help" to allow show details of single command in sub group List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, Wenchao Xia , armbru@redhat.com, lcapitulino@redhat.com A new parameter type 'S' is introduced to allow user input any string. "help info block" do not tip extra parameter error now. Signed-off-by: Wenchao Xia --- hmp-commands.hx | 2 +- monitor.c | 30 +++++++++++++++++++++++++++++- 2 files changed, 30 insertions(+), 2 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 915b0d1..8cf5f29 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -11,7 +11,7 @@ ETEXI { .name = "help|?", - .args_type = "name:s?", + .args_type = "name:S?", .params = "[cmd]", .help = "show the help", .mhandler.cmd = do_help_cmd, diff --git a/monitor.c b/monitor.c index d07f6ec..491a1b5 100644 --- a/monitor.c +++ b/monitor.c @@ -83,6 +83,7 @@ * 'F' filename * 'B' block device name * 's' string (accept optional quote) + * 'S' supported types, can be any string (accept optional quote) * 'O' option string of the form NAME=VALUE,... * parsed according to QemuOptsList given by its name * Example: 'device:O' uses qemu_device_opts. @@ -4012,6 +4013,31 @@ static const mon_cmd_t *monitor_parse_command(Monitor *mon, } } break; + case 'S': + { + /* package all remaining string */ + int len; + + while (qemu_isspace(*p)) { + p++; + } + if (*typestr == '?') { + typestr++; + if (*p == '\0') { + /* no remaining string: NULL argument */ + break; + } + } + len = strlen(p); + if (len <= 0) { + monitor_printf(mon, "%s: string expected\n", + cmdname); + break; + } + qdict_put(qdict, key, qstring_from_str(p)); + p += len; + } + break; default: bad_type: monitor_printf(mon, "%s: unknown type '%c'\n", cmdname, c); @@ -4283,7 +4309,9 @@ static void monitor_find_completion_by_table(Monitor *mon, for (i = 0; i < Q_KEY_CODE_MAX; i++) { cmd_completion(mon, str, QKeyCode_lookup[i]); } - } else if (!strcmp(cmd->name, "help|?")) { + } + case 'S': + if (!strcmp(cmd->name, "help|?")) { monitor_find_completion_by_table(mon, cmd_table, args_cmdline[1]); } -- 1.7.1