qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 18/20] vpc: Implement .bdrv_has_zero_init
Date: Fri, 28 Jun 2013 16:25:07 +0200	[thread overview]
Message-ID: <1372429509-29642-19-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1372429509-29642-1-git-send-email-kwolf@redhat.com>

Depending on the subformat, has_zero_init on VHD must behave like raw
and query the underlying storage (fixed) or like other sparse formats
that can always return 1 (dynamic, differencing).

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/vpc.c | 25 +++++++++++++++++++------
 1 file changed, 19 insertions(+), 6 deletions(-)

diff --git a/block/vpc.c b/block/vpc.c
index 3cad52e..fe4f311 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -786,6 +786,18 @@ static int vpc_create(const char *filename, QEMUOptionParameter *options)
     return ret;
 }
 
+static int vpc_has_zero_init(BlockDriverState *bs)
+{
+    BDRVVPCState *s = bs->opaque;
+    struct vhd_footer *footer =  (struct vhd_footer *) s->footer_buf;
+
+    if (cpu_to_be32(footer->type) == VHD_FIXED) {
+        return bdrv_has_zero_init(bs->file);
+    } else {
+        return 1;
+    }
+}
+
 static void vpc_close(BlockDriverState *bs)
 {
     BDRVVPCState *s = bs->opaque;
@@ -818,16 +830,17 @@ static BlockDriver bdrv_vpc = {
     .format_name    = "vpc",
     .instance_size  = sizeof(BDRVVPCState),
 
-    .bdrv_probe     = vpc_probe,
-    .bdrv_open      = vpc_open,
-    .bdrv_close     = vpc_close,
-    .bdrv_reopen_prepare = vpc_reopen_prepare,
-    .bdrv_create    = vpc_create,
+    .bdrv_probe             = vpc_probe,
+    .bdrv_open              = vpc_open,
+    .bdrv_close             = vpc_close,
+    .bdrv_reopen_prepare    = vpc_reopen_prepare,
+    .bdrv_create            = vpc_create,
 
     .bdrv_read              = vpc_co_read,
     .bdrv_write             = vpc_co_write,
 
-    .create_options = vpc_create_options,
+    .create_options         = vpc_create_options,
+    .bdrv_has_zero_init     = vpc_has_zero_init,
 };
 
 static void bdrv_vpc_init(void)
-- 
1.8.1.4

  parent reply	other threads:[~2013-06-28 14:30 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-28 14:24 [Qemu-devel] [PULL 00/20] Block patches Kevin Wolf
2013-06-28 14:24 ` [Qemu-devel] [PULL 01/20] raw-posix: Fix /dev/cdrom magic on OS X Kevin Wolf
2013-06-28 14:24 ` [Qemu-devel] [PULL 02/20] notify: add NotiferWithReturn so notifier list can abort Kevin Wolf
2013-06-28 14:24 ` [Qemu-devel] [PULL 03/20] block: add bdrv_add_before_write_notifier() Kevin Wolf
2013-06-28 14:24 ` [Qemu-devel] [PULL 04/20] block: add basic backup support to block driver Kevin Wolf
2013-06-28 14:24 ` [Qemu-devel] [PULL 05/20] blockdev: drop redundant proto_drv check Kevin Wolf
2013-06-28 14:24 ` [Qemu-devel] [PULL 06/20] blockdev: use bdrv_getlength() in qmp_drive_mirror() Kevin Wolf
2013-06-28 14:24 ` [Qemu-devel] [PULL 07/20] block: add drive-backup QMP command Kevin Wolf
2013-06-28 14:24 ` [Qemu-devel] [PULL 08/20] blockdev: rename BlkTransactionStates to singular Kevin Wolf
2013-06-28 14:24 ` [Qemu-devel] [PULL 09/20] blockdev: allow BdrvActionOps->commit() to be NULL Kevin Wolf
2013-06-28 14:24 ` [Qemu-devel] [PULL 10/20] blockdev: add DriveBackup transaction Kevin Wolf
2013-06-28 14:25 ` [Qemu-devel] [PULL 11/20] blockdev: add Abort transaction Kevin Wolf
2013-06-28 14:25 ` [Qemu-devel] [PULL 12/20] qemu-iotests: extract wait_until_completed() into iotests.py Kevin Wolf
2013-06-28 14:25 ` [Qemu-devel] [PULL 13/20] qemu-iotests: add 055 drive-backup test case Kevin Wolf
2013-06-28 14:25 ` [Qemu-devel] [PULL 14/20] block: Make BlockJobTypes const Kevin Wolf
2013-06-28 14:25 ` [Qemu-devel] [PULL 15/20] block/ssh: Set bdrv_has_zero_init according to the file type Kevin Wolf
2013-06-28 14:25 ` [Qemu-devel] [PULL 16/20] gluster: Return bdrv_has_zero_init = 0 Kevin Wolf
2013-06-28 14:25 ` [Qemu-devel] [PULL 17/20] vmdk: remove wrong calculation of relative path Kevin Wolf
2013-06-28 14:25 ` Kevin Wolf [this message]
2013-06-28 14:25 ` [Qemu-devel] [PULL 19/20] block: change default of .has_zero_init to 0 Kevin Wolf
2013-06-28 14:25 ` [Qemu-devel] [PULL 20/20] cmd646: fix build when DEBUG_IDE is enabled Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372429509-29642-19-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).