From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Usb1k-0007Wj-Uv for qemu-devel@nongnu.org; Fri, 28 Jun 2013 11:56:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Usb1i-0003eR-LM for qemu-devel@nongnu.org; Fri, 28 Jun 2013 11:56:00 -0400 Received: from cantor2.suse.de ([195.135.220.15]:44125 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Usb1i-0003dq-5U for qemu-devel@nongnu.org; Fri, 28 Jun 2013 11:55:58 -0400 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 82F12A5527 for ; Fri, 28 Jun 2013 17:55:57 +0200 (CEST) From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Fri, 28 Jun 2013 17:55:29 +0200 Message-Id: <1372434946-18489-8-git-send-email-afaerber@suse.de> In-Reply-To: <1372434946-18489-1-git-send-email-afaerber@suse.de> References: <1372434946-18489-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 07/24] gdbstub: Simplify find_cpu() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Andreas=20F=C3=A4rber?= Use qemu_get_cpu() and CPUState::env_ptr. Reviewed-by: Richard Henderson Signed-off-by: Andreas F=C3=A4rber --- gdbstub.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 94c78ce..9ffb376 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2071,17 +2071,13 @@ static void gdb_set_cpu_pc(GDBState *s, target_ul= ong pc) =20 static CPUArchState *find_cpu(uint32_t thread_id) { - CPUArchState *env; CPUState *cpu; =20 - for (env =3D first_cpu; env !=3D NULL; env =3D env->next_cpu) { - cpu =3D ENV_GET_CPU(env); - if (cpu_index(cpu) =3D=3D thread_id) { - return env; - } + cpu =3D qemu_get_cpu(thread_id); + if (cpu =3D=3D NULL) { + return NULL; } - - return NULL; + return cpu->env_ptr; } =20 static int gdb_handle_packet(GDBState *s, const char *line_buf) --=20 1.8.1.4