From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsmFW-00027p-Mm for qemu-devel@nongnu.org; Fri, 28 Jun 2013 23:55:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsmFV-0003kv-Je for qemu-devel@nongnu.org; Fri, 28 Jun 2013 23:54:58 -0400 Received: from e28smtp09.in.ibm.com ([122.248.162.9]:34547) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsmFV-0003kW-1u for qemu-devel@nongnu.org; Fri, 28 Jun 2013 23:54:57 -0400 Received: from /spool/local by e28smtp09.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 29 Jun 2013 09:20:11 +0530 Received: from d28relay04.in.ibm.com (d28relay04.in.ibm.com [9.184.220.61]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id 760B5E004F for ; Sat, 29 Jun 2013 09:24:27 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5T3sl3q28770356 for ; Sat, 29 Jun 2013 09:24:47 +0530 Received: from d28av02.in.ibm.com (loopback [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5T3spLD016943 for ; Sat, 29 Jun 2013 13:54:51 +1000 From: Wenchao Xia Date: Sat, 29 Jun 2013 11:53:00 +0800 Message-Id: <1372477981-7512-7-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1372477981-7512-1-git-send-email-xiawenc@linux.vnet.ibm.com> References: <1372477981-7512-1-git-send-email-xiawenc@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH V5 6/7] monitor: improve "help" in auto completion for sub command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, Wenchao Xia , armbru@redhat.com, lcapitulino@redhat.com Now special case "help *" in auto completion can work with sub commands, such as "help info a*". Signed-off-by: Wenchao Xia --- monitor.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index 2f5b91d..3ef18ee 100644 --- a/monitor.c +++ b/monitor.c @@ -4283,10 +4283,8 @@ static void monitor_find_completion_by_table(Monitor *mon, cmd_completion(mon, str, QKeyCode_lookup[i]); } } else if (!strcmp(cmd->name, "help|?")) { - readline_set_completion_index(mon->rs, strlen(str)); - for (cmd = mon->cmd_table; cmd->name != NULL; cmd++) { - cmd_completion(mon, str, cmd->name); - } + monitor_find_completion_by_table(mon, cmd_table, + args_cmdline[1]); } break; default: -- 1.7.1