qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: qemu-ppc@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	programmingkidx@gmail.com, mark.cave-ayland@ilande.co.uk,
	qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 11/17] PPC: dbdma: macio: Add DMA callback
Date: Mon,  1 Jul 2013 02:13:36 +0200	[thread overview]
Message-ID: <1372637622-50697-12-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1372637622-50697-1-git-send-email-agraf@suse.de>

We need to know when the IDE core starts a DMA transfer. Add a notifier
function so we have the chance to start transmitting data.

Signed-off-by: Alexander Graf <agraf@suse.de>

---

v1 -> v2:

  - fix dprintf
---
 hw/ide/macio.c | 40 ++++++++++++++++++++++++++++++++++++++++
 hw/ppc/mac.h   |  2 ++
 2 files changed, 42 insertions(+)

diff --git a/hw/ide/macio.c b/hw/ide/macio.c
index fceadfe..2729c62 100644
--- a/hw/ide/macio.c
+++ b/hw/ide/macio.c
@@ -359,11 +359,50 @@ static void macio_ide_reset(DeviceState *dev)
     ide_bus_reset(&d->bus);
 }
 
+static int ide_nop(IDEDMA *dma)
+{
+    return 0;
+}
+
+static int ide_nop_int(IDEDMA *dma, int x)
+{
+    return 0;
+}
+
+static void ide_nop_restart(void *opaque, int x, RunState y)
+{
+}
+
+static void ide_dbdma_start(IDEDMA *dma, IDEState *s,
+                            BlockDriverCompletionFunc *cb)
+{
+    MACIOIDEState *m = container_of(dma, MACIOIDEState, dma);
+
+    MACIO_DPRINTF("\n");
+    DBDMA_kick(m->dbdma);
+}
+
+static const IDEDMAOps dbdma_ops = {
+    .start_dma      = ide_dbdma_start,
+    .start_transfer = ide_nop,
+    .prepare_buf    = ide_nop_int,
+    .rw_buf         = ide_nop_int,
+    .set_unit       = ide_nop_int,
+    .add_status     = ide_nop_int,
+    .set_inactive   = ide_nop,
+    .restart_cb     = ide_nop_restart,
+    .reset          = ide_nop,
+};
+
 static void macio_ide_realizefn(DeviceState *dev, Error **errp)
 {
     MACIOIDEState *s = MACIO_IDE(dev);
 
     ide_init2(&s->bus, s->irq);
+
+    /* Register DMA callbacks */
+    s->dma.ops = &dbdma_ops;
+    s->bus.dma = &s->dma;
 }
 
 static void macio_ide_initfn(Object *obj)
@@ -414,6 +453,7 @@ void macio_ide_init_drives(MACIOIDEState *s, DriveInfo **hd_table)
 
 void macio_ide_register_dma(MACIOIDEState *s, void *dbdma, int channel)
 {
+    s->dbdma = dbdma;
     DBDMA_register_channel(dbdma, channel, s->dma_irq,
                            pmac_ide_transfer, pmac_ide_flush, s);
 }
diff --git a/hw/ppc/mac.h b/hw/ppc/mac.h
index 54efaed..27c4ca3 100644
--- a/hw/ppc/mac.h
+++ b/hw/ppc/mac.h
@@ -131,6 +131,8 @@ typedef struct MACIOIDEState {
     MemoryRegion mem;
     IDEBus bus;
     BlockDriverAIOCB *aiocb;
+    IDEDMA dma;
+    void *dbdma;
 } MACIOIDEState;
 
 void macio_ide_init_drives(MACIOIDEState *ide, DriveInfo **hd_table);
-- 
1.8.1.4

  parent reply	other threads:[~2013-07-01  0:13 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-01  0:13 [Qemu-devel] [PATCH 00/17] PPC: Mac OS X guest bringup v2 Alexander Graf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 01/17] PPC: Mac: Fix guest exported tbfreq values Alexander Graf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 02/17] PPC: g3beige: Move secondary IDE bus to mac-io Alexander Graf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 03/17] PPC: Macio: Replace tabs with spaces Alexander Graf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 04/17] PPC: dbdma: " Alexander Graf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 05/17] PPC: Mac: Add debug prints in macio and dbdma code Alexander Graf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 06/17] PPC: dbdma: Fix debug print Alexander Graf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 07/17] PPC: dbdma: Allow new commands in RUN state Alexander Graf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 08/17] PPC: dbdma: Move defines into header file Alexander Graf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 09/17] PPC: dbdma: Introduce kick function Alexander Graf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 10/17] PPC: dbdma: Move static bh variable to device struct Alexander Graf
2013-07-01  0:13 ` Alexander Graf [this message]
2013-07-01  0:13 ` [Qemu-devel] [PATCH 12/17] PPC: dbdma: Move processing to io Alexander Graf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 13/17] PPC: dbdma: Wait for DMA until we have data Alexander Graf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 14/17] PPC: dbdma: Support unaligned DMA access Alexander Graf
2013-07-17  9:09   ` Kevin Wolf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 15/17] PPC: Add timer handler for newworld mac-io Alexander Graf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 17/17] PPC: dbdma: Support more multi-issue DMA requests Alexander Graf
2013-07-11 14:22 ` [Qemu-devel] [Qemu-ppc] [PATCH 00/17] PPC: Mac OS X guest bringup v2 Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372637622-50697-12-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=kwolf@redhat.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=programmingkidx@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).