qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: qemu-ppc@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	programmingkidx@gmail.com, mark.cave-ayland@ilande.co.uk,
	qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 01/17] PPC: Mac: Fix guest exported tbfreq values
Date: Mon,  1 Jul 2013 02:13:26 +0200	[thread overview]
Message-ID: <1372637622-50697-2-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1372637622-50697-1-git-send-email-agraf@suse.de>

We can tell the guest the frequency of its time base through fwcfg.

However, we tell it a different value from the speed tb actually runs
at. Let's fix it and make the tbfreq initialization and the fwcfg exposure
use the same values.

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 hw/ppc/mac_newworld.c | 5 +++--
 hw/ppc/mac_oldworld.c | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c
index 3badfa3..253089a 100644
--- a/hw/ppc/mac_newworld.c
+++ b/hw/ppc/mac_newworld.c
@@ -71,6 +71,7 @@
 
 #define MAX_IDE_BUS 2
 #define CFG_ADDR 0xf0000510
+#define TBFREQ (100UL * 1000UL * 1000UL)
 
 /* debug UniNorth */
 //#define DEBUG_UNIN
@@ -191,7 +192,7 @@ static void ppc_core99_init(QEMUMachineInitArgs *args)
         env = &cpu->env;
 
         /* Set time-base frequency to 100 Mhz */
-        cpu_ppc_tb_init(env, 100UL * 1000UL * 1000UL);
+        cpu_ppc_tb_init(env, TBFREQ);
         qemu_register_reset(ppc_core99_reset, cpu);
     }
 
@@ -460,7 +461,7 @@ static void ppc_core99_init(QEMUMachineInitArgs *args)
         fw_cfg_add_i32(fw_cfg, FW_CFG_PPC_KVM_PID, getpid());
 #endif
     } else {
-        fw_cfg_add_i32(fw_cfg, FW_CFG_PPC_TBFREQ, get_ticks_per_sec());
+        fw_cfg_add_i32(fw_cfg, FW_CFG_PPC_TBFREQ, TBFREQ);
     }
     /* Mac OS X requires a "known good" clock-frequency value; pass it one. */
     fw_cfg_add_i32(fw_cfg, FW_CFG_PPC_CLOCKFREQ, 266000000);
diff --git a/hw/ppc/mac_oldworld.c b/hw/ppc/mac_oldworld.c
index 8faff30..2aab54c 100644
--- a/hw/ppc/mac_oldworld.c
+++ b/hw/ppc/mac_oldworld.c
@@ -45,6 +45,7 @@
 
 #define MAX_IDE_BUS 2
 #define CFG_ADDR 0xf0000510
+#define TBFREQ 16600000UL
 
 static int fw_cfg_boot_set(void *opaque, const char *boot_device)
 {
@@ -114,7 +115,7 @@ static void ppc_heathrow_init(QEMUMachineInitArgs *args)
         env = &cpu->env;
 
         /* Set time-base frequency to 16.6 Mhz */
-        cpu_ppc_tb_init(env,  16600000UL);
+        cpu_ppc_tb_init(env,  TBFREQ);
         qemu_register_reset(ppc_heathrow_reset, cpu);
     }
 
@@ -331,7 +332,7 @@ static void ppc_heathrow_init(QEMUMachineInitArgs *args)
         fw_cfg_add_i32(fw_cfg, FW_CFG_PPC_KVM_PID, getpid());
 #endif
     } else {
-        fw_cfg_add_i32(fw_cfg, FW_CFG_PPC_TBFREQ, get_ticks_per_sec());
+        fw_cfg_add_i32(fw_cfg, FW_CFG_PPC_TBFREQ, TBFREQ);
     }
     /* Mac OS X requires a "known good" clock-frequency value; pass it one. */
     fw_cfg_add_i32(fw_cfg, FW_CFG_PPC_CLOCKFREQ, 266000000);
-- 
1.8.1.4

  reply	other threads:[~2013-07-01  0:13 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-01  0:13 [Qemu-devel] [PATCH 00/17] PPC: Mac OS X guest bringup v2 Alexander Graf
2013-07-01  0:13 ` Alexander Graf [this message]
2013-07-01  0:13 ` [Qemu-devel] [PATCH 02/17] PPC: g3beige: Move secondary IDE bus to mac-io Alexander Graf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 03/17] PPC: Macio: Replace tabs with spaces Alexander Graf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 04/17] PPC: dbdma: " Alexander Graf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 05/17] PPC: Mac: Add debug prints in macio and dbdma code Alexander Graf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 06/17] PPC: dbdma: Fix debug print Alexander Graf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 07/17] PPC: dbdma: Allow new commands in RUN state Alexander Graf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 08/17] PPC: dbdma: Move defines into header file Alexander Graf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 09/17] PPC: dbdma: Introduce kick function Alexander Graf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 10/17] PPC: dbdma: Move static bh variable to device struct Alexander Graf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 11/17] PPC: dbdma: macio: Add DMA callback Alexander Graf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 12/17] PPC: dbdma: Move processing to io Alexander Graf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 13/17] PPC: dbdma: Wait for DMA until we have data Alexander Graf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 14/17] PPC: dbdma: Support unaligned DMA access Alexander Graf
2013-07-17  9:09   ` Kevin Wolf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 15/17] PPC: Add timer handler for newworld mac-io Alexander Graf
2013-07-01  0:13 ` [Qemu-devel] [PATCH 17/17] PPC: dbdma: Support more multi-issue DMA requests Alexander Graf
2013-07-11 14:22 ` [Qemu-devel] [Qemu-ppc] [PATCH 00/17] PPC: Mac OS X guest bringup v2 Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372637622-50697-2-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=kwolf@redhat.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=programmingkidx@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).