From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH v5 12/18] block/rbd: drop qemu_rbd_aio_flush_cb()
Date: Mon, 1 Jul 2013 14:18:43 +0200 [thread overview]
Message-ID: <1372681129-18528-13-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1372681129-18528-1-git-send-email-stefanha@redhat.com>
.io_flush() is no longer called so drop qemu_rbd_aio_flush_cb().
qemu_aio_count is unused now so drop it too.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
block/rbd.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index cb71751..71b4a0c 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -100,7 +100,6 @@ typedef struct BDRVRBDState {
rados_ioctx_t io_ctx;
rbd_image_t image;
char name[RBD_MAX_IMAGE_NAME_SIZE];
- int qemu_aio_count;
char *snap;
int event_reader_pos;
RADOSCB *event_rcb;
@@ -428,19 +427,11 @@ static void qemu_rbd_aio_event_reader(void *opaque)
if (s->event_reader_pos == sizeof(s->event_rcb)) {
s->event_reader_pos = 0;
qemu_rbd_complete_aio(s->event_rcb);
- s->qemu_aio_count--;
}
}
} while (ret < 0 && errno == EINTR);
}
-static int qemu_rbd_aio_flush_cb(void *opaque)
-{
- BDRVRBDState *s = opaque;
-
- return (s->qemu_aio_count > 0);
-}
-
/* TODO Convert to fine grained options */
static QemuOptsList runtime_opts = {
.name = "rbd",
@@ -554,7 +545,7 @@ static int qemu_rbd_open(BlockDriverState *bs, QDict *options, int flags)
fcntl(s->fds[0], F_SETFL, O_NONBLOCK);
fcntl(s->fds[1], F_SETFL, O_NONBLOCK);
qemu_aio_set_fd_handler(s->fds[RBD_FD_READ], qemu_rbd_aio_event_reader,
- NULL, qemu_rbd_aio_flush_cb, s);
+ NULL, NULL, s);
qemu_opts_del(opts);
@@ -741,8 +732,6 @@ static BlockDriverAIOCB *rbd_start_aio(BlockDriverState *bs,
off = sector_num * BDRV_SECTOR_SIZE;
size = nb_sectors * BDRV_SECTOR_SIZE;
- s->qemu_aio_count++; /* All the RADOSCB */
-
rcb = g_malloc(sizeof(RADOSCB));
rcb->done = 0;
rcb->acb = acb;
@@ -779,7 +768,6 @@ static BlockDriverAIOCB *rbd_start_aio(BlockDriverState *bs,
failed:
g_free(rcb);
- s->qemu_aio_count--;
qemu_aio_release(acb);
return NULL;
}
--
1.8.1.4
next prev parent reply other threads:[~2013-07-01 12:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 12:18 [Qemu-devel] [PATCH v5 00/18] aio: drop io_flush() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 01/18] block: ensure bdrv_drain_all() works during bdrv_delete() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 02/18] block: stop relying on io_flush() in bdrv_drain_all() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 03/18] dataplane/virtio-blk: check exit conditions before aio_poll() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 04/18] tests: adjust test-aio to new aio_poll() semantics Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 05/18] tests: adjust test-thread-pool " Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 06/18] aio: stop using .io_flush() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 07/18] block/curl: drop curl_aio_flush() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 08/18] block/gluster: drop qemu_gluster_aio_flush_cb() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 09/18] block/iscsi: drop iscsi_process_flush() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 10/18] block/linux-aio: drop qemu_laio_completion_cb() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 11/18] block/nbd: drop nbd_have_request() Stefan Hajnoczi
2013-07-01 12:18 ` Stefan Hajnoczi [this message]
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 13/18] block/sheepdog: drop have_co_req() and aio_flush_request() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 14/18] block/ssh: drop return_true() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 15/18] dataplane/virtio-blk: drop flush_true() and flush_io() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 16/18] thread-pool: drop thread_pool_active() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 17/18] tests: drop event_active_cb() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 18/18] aio: drop io_flush argument Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372681129-18528-13-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).