qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH v5 03/18] dataplane/virtio-blk: check exit conditions before aio_poll()
Date: Mon,  1 Jul 2013 14:18:34 +0200	[thread overview]
Message-ID: <1372681129-18528-4-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1372681129-18528-1-git-send-email-stefanha@redhat.com>

Check exit conditions before entering blocking aio_poll().  This is
mainly for consistency since it's unlikely that we are stopping in the
first event loop iteration.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 hw/block/dataplane/virtio-blk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
index 0356665..0509d3f 100644
--- a/hw/block/dataplane/virtio-blk.c
+++ b/hw/block/dataplane/virtio-blk.c
@@ -379,9 +379,9 @@ static void *data_plane_thread(void *opaque)
 {
     VirtIOBlockDataPlane *s = opaque;
 
-    do {
+    while (!s->stopping || s->num_reqs > 0) {
         aio_poll(s->ctx, true);
-    } while (!s->stopping || s->num_reqs > 0);
+    }
     return NULL;
 }
 
-- 
1.8.1.4

  parent reply	other threads:[~2013-07-01 12:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-01 12:18 [Qemu-devel] [PATCH v5 00/18] aio: drop io_flush() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 01/18] block: ensure bdrv_drain_all() works during bdrv_delete() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 02/18] block: stop relying on io_flush() in bdrv_drain_all() Stefan Hajnoczi
2013-07-01 12:18 ` Stefan Hajnoczi [this message]
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 04/18] tests: adjust test-aio to new aio_poll() semantics Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 05/18] tests: adjust test-thread-pool " Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 06/18] aio: stop using .io_flush() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 07/18] block/curl: drop curl_aio_flush() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 08/18] block/gluster: drop qemu_gluster_aio_flush_cb() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 09/18] block/iscsi: drop iscsi_process_flush() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 10/18] block/linux-aio: drop qemu_laio_completion_cb() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 11/18] block/nbd: drop nbd_have_request() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 12/18] block/rbd: drop qemu_rbd_aio_flush_cb() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 13/18] block/sheepdog: drop have_co_req() and aio_flush_request() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 14/18] block/ssh: drop return_true() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 15/18] dataplane/virtio-blk: drop flush_true() and flush_io() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 16/18] thread-pool: drop thread_pool_active() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 17/18] tests: drop event_active_cb() Stefan Hajnoczi
2013-07-01 12:18 ` [Qemu-devel] [PATCH v5 18/18] aio: drop io_flush argument Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372681129-18528-4-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).