qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, obarenbo@redhat.com,
	roliveri@redhat.com, hbrock@redhat.com, rjones@redhat.com,
	armbru@redhat.com, pmyers@redhat.com, imain@redhat.com,
	stefanha@redhat.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH 7/7] block: assign backing relationship in drive-backup
Date: Tue,  2 Jul 2013 13:59:49 +0800	[thread overview]
Message-ID: <1372744789-997-8-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1372744789-997-1-git-send-email-famz@redhat.com>

Assign source image as the backing hd of target bs, so reading target bs
gets the point-in-time copy of data from source image.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 block/backup.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/block/backup.c b/block/backup.c
index 4e9f927..2dd0540 100644
--- a/block/backup.c
+++ b/block/backup.c
@@ -294,6 +294,11 @@ static void coroutine_fn backup_run(void *opaque)
     hbitmap_free(job->bitmap);
 
     bdrv_iostatus_disable(target);
+
+    bdrv_put_ref(target->backing_hd);
+    target->backing_hd = NULL;
+    target->backing_file[0] = '\0';
+    target->backing_format[0] = '\0';
     bdrv_put_ref(target);
 
     block_job_completed(&job->common, ret);
@@ -332,7 +337,15 @@ void backup_start(BlockDriverState *bs, BlockDriverState *target,
         return;
     }
 
+    target->backing_hd = bs;
+    pstrcpy(target->backing_file, sizeof(target->backing_file),
+            bs->filename);
+    pstrcpy(target->backing_format, sizeof(target->backing_format),
+            bs->drv->format_name);
     bdrv_get_ref(target);
+    /* Get another ref to source for backing_hd relationship */
+    bdrv_get_ref(bs);
+
     job->on_source_error = on_source_error;
     job->on_target_error = on_target_error;
     job->target = target;
-- 
1.8.3.1

  parent reply	other threads:[~2013-07-02  6:02 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-02  5:59 [Qemu-devel] [PATCH 0/7] Point-in-time snapshot exporting over NBD Fam Zheng
2013-07-02  5:59 ` [Qemu-devel] [PATCH 1/7] block: Convert BlockDriverState.in_use to refcount Fam Zheng
2013-07-02 10:21   ` Paolo Bonzini
2013-07-08  8:37     ` Fam Zheng
2013-07-02 19:41   ` Eric Blake
2013-07-03  0:59     ` Fam Zheng
2013-07-02  5:59 ` [Qemu-devel] [PATCH 2/7] block: use refcount to manage BlockDriverState lifecycle Fam Zheng
2013-07-02  5:59 ` [Qemu-devel] [PATCH 3/7] nbd: use BDS refcount Fam Zheng
2013-07-02 10:16   ` Paolo Bonzini
2013-07-03  1:10     ` Fam Zheng
2013-07-03  5:58       ` Paolo Bonzini
2013-07-03  6:30         ` Fam Zheng
2013-07-03  7:28           ` Paolo Bonzini
2013-07-02  5:59 ` [Qemu-devel] [PATCH 4/7] block: simplify bdrv_drop_intermediate Fam Zheng
2013-07-04 14:02   ` Stefan Hajnoczi
2013-07-05  1:00     ` Fam Zheng
2013-07-02  5:59 ` [Qemu-devel] [PATCH 5/7] block: rename bdrv_in_use to bdrv_is_shared Fam Zheng
2013-07-02  5:59 ` [Qemu-devel] [PATCH 6/7] block: add target-id option to drive-backup QMP command Fam Zheng
2013-07-02 19:59   ` Eric Blake
2013-07-02  5:59 ` Fam Zheng [this message]
2013-07-04 14:32   ` [Qemu-devel] [PATCH 7/7] block: assign backing relationship in drive-backup Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372744789-997-8-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=armbru@redhat.com \
    --cc=hbrock@redhat.com \
    --cc=imain@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=obarenbo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=pmyers@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    --cc=roliveri@redhat.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).