From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UuTNW-0001oX-Hc for qemu-devel@nongnu.org; Wed, 03 Jul 2013 16:10:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UuTNV-0002gx-2e for qemu-devel@nongnu.org; Wed, 03 Jul 2013 16:10:14 -0400 Message-ID: <1372882200.2883.208.camel@ul30vt.home> From: Alex Williamson Date: Wed, 03 Jul 2013 14:10:00 -0600 In-Reply-To: <1371073298-14519-10-git-send-email-mdroth@linux.vnet.ibm.com> References: <1371073298-14519-1-git-send-email-mdroth@linux.vnet.ibm.com> <1371073298-14519-10-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 09/26] ide: Set BSY bit during FLUSH List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org On Wed, 2013-06-12 at 16:41 -0500, Michael Roth wrote: > From: Andreas F=C3=A4rber >=20 > The implementation of the ATA FLUSH command invokes a flush at the bloc= k > layer, which may on raw files on POSIX entail a synchronous fdatasync(). > This may in some cases take so long that the SLES 11 SP1 guest driver > reports I/O errors and filesystems get corrupted or remounted read-only. >=20 > Avoid this by setting BUSY_STAT, so that the guest is made aware we are > in the middle of an operation and no ATA commands are attempted to be > processed concurrently. >=20 > Addresses BNC#637297. >=20 > Suggested-by: Gonglei (Arei) > Signed-off-by: Andreas F=C3=A4rber > Signed-off-by: Kevin Wolf > Signed-off-by: Stefan Hajnoczi > (cherry picked from commit f68ec8379e88502b4841a110c070e9b118d3151c) >=20 > Signed-off-by: Michael Roth > --- > hw/ide/core.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/hw/ide/core.c b/hw/ide/core.c > index c7a8041..9926d92 100644 > --- a/hw/ide/core.c > +++ b/hw/ide/core.c > @@ -814,6 +814,7 @@ void ide_flush_cache(IDEState *s) > return; > } > =20 > + s->status |=3D BUSY_STAT; > bdrv_acct_start(s->bs, &s->acct, 0, BDRV_ACCT_FLUSH); > bdrv_aio_flush(s->bs, ide_flush_cb, s); > } This caused a regression for me from 1.5.0->1.5.1. Windows 7 x64 no longer boots on q35 IDE with this change. Thanks, Alex