From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, claudio.fontana@huawei.com, afaerber@suse.de
Subject: [Qemu-devel] [PATCH v3 09/14] tcg-arm: Simplify logic in detecting the ARM ISA in use
Date: Wed, 3 Jul 2013 14:29:23 -0700 [thread overview]
Message-ID: <1372886968-17497-10-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1372886968-17497-1-git-send-email-rth@twiddle.net>
GCC 4.8 defines a handy __ARM_ARCH symbol that we can use, which
will make us nicely forward compatible with ARMv8 AArch32.
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
tcg/arm/tcg-target.c | 62 +++++++++++++++++-----------------------------------
1 file changed, 20 insertions(+), 42 deletions(-)
diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c
index 2c46ceb..763b173 100644
--- a/tcg/arm/tcg-target.c
+++ b/tcg/arm/tcg-target.c
@@ -22,50 +22,28 @@
* THE SOFTWARE.
*/
-#if defined(__ARM_ARCH_7__) || \
- defined(__ARM_ARCH_7A__) || \
- defined(__ARM_ARCH_7EM__) || \
- defined(__ARM_ARCH_7M__) || \
- defined(__ARM_ARCH_7R__)
-#define USE_ARMV7_INSTRUCTIONS
+/* The __ARM_ARCH define is provided by gcc 4.8. Construct it otherwise. */
+#ifndef __ARM_ARCH
+# if defined(__ARM_ARCH_7__) || defined(__ARM_ARCH_7A__) \
+ || defined(__ARM_ARCH_7R__) || defined(__ARM_ARCH_7M__) \
+ || defined(__ARM_ARCH_7EM__)
+# define __ARM_ARCH 7
+# elif defined(__ARM_ARCH_6__) || defined(__ARM_ARCH_6J__) \
+ || defined(__ARM_ARCH_6Z__) || defined(__ARM_ARCH_6ZK__) \
+ || defined(__ARM_ARCH_6K__) || defined(__ARM_ARCH_6T2__)
+# define __ARM_ARCH 6
+# elif defined(__ARM_ARCH_5__) || defined(__ARM_ARCH_5E__) \
+ || defined(__ARM_ARCH_5T__) || defined(__ARM_ARCH_5TE__) \
+ || defined(__ARM_ARCH_5TEJ__)
+# define __ARM_ARCH 5
+# else
+# define __ARM_ARCH 4
+# endif
#endif
-#if defined(USE_ARMV7_INSTRUCTIONS) || \
- defined(__ARM_ARCH_6J__) || \
- defined(__ARM_ARCH_6K__) || \
- defined(__ARM_ARCH_6T2__) || \
- defined(__ARM_ARCH_6Z__) || \
- defined(__ARM_ARCH_6ZK__)
-#define USE_ARMV6_INSTRUCTIONS
-#endif
-
-#if defined(USE_ARMV6_INSTRUCTIONS) || \
- defined(__ARM_ARCH_5T__) || \
- defined(__ARM_ARCH_5TE__) || \
- defined(__ARM_ARCH_5TEJ__)
-#define USE_ARMV5_INSTRUCTIONS
-#endif
-
-#ifdef USE_ARMV5_INSTRUCTIONS
-static const int use_armv5_instructions = 1;
-#else
-static const int use_armv5_instructions = 0;
-#endif
-#undef USE_ARMV5_INSTRUCTIONS
-
-#ifdef USE_ARMV6_INSTRUCTIONS
-static const int use_armv6_instructions = 1;
-#else
-static const int use_armv6_instructions = 0;
-#endif
-#undef USE_ARMV6_INSTRUCTIONS
-
-#ifdef USE_ARMV7_INSTRUCTIONS
-static const int use_armv7_instructions = 1;
-#else
-static const int use_armv7_instructions = 0;
-#endif
-#undef USE_ARMV7_INSTRUCTIONS
+#define use_armv5_instructions (__ARM_ARCH >= 5)
+#define use_armv6_instructions (__ARM_ARCH >= 6)
+#define use_armv7_instructions (__ARM_ARCH >= 7)
#ifndef use_idiv_instructions
bool use_idiv_instructions;
--
1.8.1.4
next prev parent reply other threads:[~2013-07-03 21:30 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 21:29 [Qemu-devel] [PATCH v3 00/14] tcg: remainder and tcg-arm updates Richard Henderson
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 01/14] tcg: Add myself to general TCG maintainership Richard Henderson
2013-07-04 10:38 ` Peter Maydell
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 02/14] tcg: Split rem requirement from div requirement Richard Henderson
2013-07-04 10:44 ` Peter Maydell
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 03/14] tcg-arm: Don't implement rem Richard Henderson
2013-07-04 10:45 ` Peter Maydell
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 04/14] tcg-ppc: " Richard Henderson
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 05/14] tcg-ppc64: " Richard Henderson
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 06/14] tcg: Allow non-constant control macros Richard Henderson
2013-07-04 10:53 ` Peter Maydell
2013-07-04 17:28 ` Richard Henderson
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 07/14] tcg: Simplify logic using TCG_OPF_NOT_PRESENT Richard Henderson
2013-07-04 10:54 ` Peter Maydell
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 08/14] tcg-arm: Make use of conditional availability of opcodes for divide Richard Henderson
2013-07-04 11:02 ` Peter Maydell
2013-07-04 17:33 ` Richard Henderson
2013-07-04 17:39 ` Peter Maydell
2013-07-03 21:29 ` Richard Henderson [this message]
2013-07-04 11:22 ` [Qemu-devel] [PATCH v3 09/14] tcg-arm: Simplify logic in detecting the ARM ISA in use Peter Maydell
2013-07-04 17:44 ` Richard Henderson
2013-07-04 19:29 ` Peter Maydell
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 10/14] tcg-arm: Use AT_PLATFORM to detect the host ISA Richard Henderson
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 11/14] tcg: Fix high_pc fields in .debug_info Richard Henderson
2013-07-04 11:25 ` Peter Maydell
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 12/14] tcg: Move the CIE and FDE header definitions to common code Richard Henderson
2013-07-04 11:29 ` Peter Maydell
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 13/14] tcg-i386: Use QEMU_BUILD_BUG_ON instead of assert for frame size Richard Henderson
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 14/14] tcg-arm: Implement tcg_register_jit Richard Henderson
2013-07-04 11:29 ` Peter Maydell
2013-07-04 9:28 ` [Qemu-devel] [PATCH v3 00/14] tcg: remainder and tcg-arm updates Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372886968-17497-10-git-send-email-rth@twiddle.net \
--to=rth@twiddle.net \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=claudio.fontana@huawei.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).