From: Xu Wang <cngesaint@gmail.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@gmail.com,
Xu Wang <cngesaint@gmail.com>,
xiawenc@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH V2 4/5] Add backing file loop check in change_backing_file()
Date: Mon, 8 Jul 2013 03:26:05 -0400 [thread overview]
Message-ID: <1373268366-14508-5-git-send-email-cngesaint@gmail.com> (raw)
In-Reply-To: <1373268366-14508-1-git-send-email-cngesaint@gmail.com>
Signed-off-by: Xu Wang <cngesaint@gmail.com>
---
block.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/block.c b/block.c
index 6df25d9..379b79b 100644
--- a/block.c
+++ b/block.c
@@ -1971,6 +1971,12 @@ int bdrv_change_backing_file(BlockDriverState *bs,
return -EINVAL;
}
+ /* Check if loop exists in backing files chain after changed */
+ if (bdrv_backing_file_loop_check(bs->filename, NULL, true, backing_file,
+ backing_fmt)) {
+ return -EIO;
+ }
+
if (drv->bdrv_change_backing_file != NULL) {
ret = drv->bdrv_change_backing_file(bs, backing_file, backing_fmt);
} else {
--
1.8.1.4
next prev parent reply other threads:[~2013-07-08 7:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 7:26 [Qemu-devel] [PATCH V2 0/5] Add infinite loop check for backing file chain Xu Wang
2013-07-08 7:26 ` [Qemu-devel] [PATCH V2 1/5] Refine and export infinite loop checking in collect_image_info_list() Xu Wang
2013-07-10 10:25 ` Fam Zheng
2013-07-10 10:49 ` Fam Zheng
2013-07-12 2:58 ` Xu Wang
2013-07-08 7:26 ` [Qemu-devel] [PATCH V2 2/5] Add WIN32 platform support for backing_file_loop_check() Xu Wang
2013-07-10 10:44 ` Fam Zheng
2013-07-15 6:09 ` Xu Wang
2013-07-15 6:30 ` Fam Zheng
2013-07-08 7:26 ` [Qemu-devel] [PATCH V2 3/5] Check infinite loop in bdrv_img_create() Xu Wang
2013-07-10 10:52 ` Fam Zheng
2013-07-08 7:26 ` Xu Wang [this message]
2013-07-10 10:57 ` [Qemu-devel] [PATCH V2 4/5] Add backing file loop check in change_backing_file() Fam Zheng
2013-07-08 7:26 ` [Qemu-devel] [PATCH V2 5/5] Add infinite loop check in drive_init() Xu Wang
2013-07-10 11:00 ` Fam Zheng
2013-07-10 11:13 ` [Qemu-devel] [PATCH V2 0/5] Add infinite loop check for backing file chain Fam Zheng
2013-07-10 11:42 ` Kevin Wolf
2013-07-10 17:20 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373268366-14508-5-git-send-email-cngesaint@gmail.com \
--to=cngesaint@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).