From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48050) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uw5qG-0008UN-9W for qemu-devel@nongnu.org; Mon, 08 Jul 2013 03:26:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uw5qC-0005U0-PP for qemu-devel@nongnu.org; Mon, 08 Jul 2013 03:26:36 -0400 Received: from mail-pd0-x22e.google.com ([2607:f8b0:400e:c02::22e]:42287) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uw5qC-0005Tp-I8 for qemu-devel@nongnu.org; Mon, 08 Jul 2013 03:26:32 -0400 Received: by mail-pd0-f174.google.com with SMTP id 10so3790541pdc.19 for ; Mon, 08 Jul 2013 00:26:31 -0700 (PDT) From: Xu Wang Date: Mon, 8 Jul 2013 03:26:05 -0400 Message-Id: <1373268366-14508-5-git-send-email-cngesaint@gmail.com> In-Reply-To: <1373268366-14508-1-git-send-email-cngesaint@gmail.com> References: <1373268366-14508-1-git-send-email-cngesaint@gmail.com> Subject: [Qemu-devel] [PATCH V2 4/5] Add backing file loop check in change_backing_file() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@gmail.com, Xu Wang , xiawenc@linux.vnet.ibm.com Signed-off-by: Xu Wang --- block.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/block.c b/block.c index 6df25d9..379b79b 100644 --- a/block.c +++ b/block.c @@ -1971,6 +1971,12 @@ int bdrv_change_backing_file(BlockDriverState *bs, return -EINVAL; } + /* Check if loop exists in backing files chain after changed */ + if (bdrv_backing_file_loop_check(bs->filename, NULL, true, backing_file, + backing_fmt)) { + return -EIO; + } + if (drv->bdrv_change_backing_file != NULL) { ret = drv->bdrv_change_backing_file(bs, backing_file, backing_fmt); } else { -- 1.8.1.4