From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com
Subject: [Qemu-devel] [PULL 14/15] tcg-i386: Use QEMU_BUILD_BUG_ON instead of assert for frame size
Date: Tue, 9 Jul 2013 07:18:34 -0700 [thread overview]
Message-ID: <1373379515-28596-15-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1373379515-28596-1-git-send-email-rth@twiddle.net>
We can check the condition at compile time, rather than run time.
Reviewed-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
tcg/i386/tcg-target.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c
index ae3de09..87eeab3 100644
--- a/tcg/i386/tcg-target.c
+++ b/tcg/i386/tcg-target.c
@@ -2318,6 +2318,9 @@ typedef struct {
uint8_t fde_reg_ofs[14];
} DebugFrame;
+/* We're expecting a 2 byte uleb128 encoded value. */
+QEMU_BUILD_BUG_ON(FRAME_SIZE >= (1 << 14));
+
#if !defined(__ELF__)
/* Host machine without ELF. */
#elif TCG_TARGET_REG_BITS == 64
@@ -2381,9 +2384,6 @@ static DebugFrame debug_frame = {
#if defined(ELF_HOST_MACHINE)
void tcg_register_jit(void *buf, size_t buf_size)
{
- /* We're expecting a 2 byte uleb128 encoded value. */
- assert(FRAME_SIZE >> 14 == 0);
-
debug_frame.fde.func_start = (tcg_target_long) buf;
debug_frame.fde.func_len = buf_size;
--
1.8.1.4
next prev parent reply other threads:[~2013-07-09 14:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 14:18 [Qemu-devel] [PULL 00/15] tcg: remainder and tcg-arm updates Richard Henderson
2013-07-09 14:18 ` [Qemu-devel] [PULL 01/15] tcg: Add myself to general TCG maintainership Richard Henderson
2013-07-09 14:18 ` [Qemu-devel] [PULL 02/15] tcg: Split rem requirement from div requirement Richard Henderson
2013-07-09 14:18 ` [Qemu-devel] [PULL 03/15] tcg-arm: Don't implement rem Richard Henderson
2013-07-09 14:18 ` [Qemu-devel] [PULL 04/15] tcg-ppc: " Richard Henderson
2013-07-09 14:18 ` [Qemu-devel] [PULL 05/15] tcg-ppc64: " Richard Henderson
2013-07-09 14:18 ` [Qemu-devel] [PULL 06/15] tcg: Allow non-constant control macros Richard Henderson
2013-07-09 14:18 ` [Qemu-devel] [PULL 07/15] tcg: Simplify logic using TCG_OPF_NOT_PRESENT Richard Henderson
2013-07-09 14:18 ` [Qemu-devel] [PULL 08/15] tcg-arm: Make use of conditional availability of opcodes for divide Richard Henderson
2013-07-09 14:18 ` [Qemu-devel] [PULL 09/15] tcg-arm: Rename use_armv5_instructions to use_armvt5_instructions Richard Henderson
2013-07-09 14:18 ` [Qemu-devel] [PULL 10/15] tcg-arm: Simplify logic in detecting the ARM ISA in use Richard Henderson
2013-07-09 14:18 ` [Qemu-devel] [PULL 11/15] tcg-arm: Use AT_PLATFORM to detect the host ISA Richard Henderson
2013-07-09 14:18 ` [Qemu-devel] [PULL 12/15] tcg: Fix high_pc fields in .debug_info Richard Henderson
2013-07-09 14:18 ` [Qemu-devel] [PULL 13/15] tcg: Move the CIE and FDE header definitions to common code Richard Henderson
2013-07-09 14:18 ` Richard Henderson [this message]
2013-07-09 14:18 ` [Qemu-devel] [PULL 15/15] tcg-arm: Implement tcg_register_jit Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373379515-28596-15-git-send-email-rth@twiddle.net \
--to=rth@twiddle.net \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).