qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com
Subject: [Qemu-devel] [PULL 04/15] tcg-ppc: Don't implement rem
Date: Tue,  9 Jul 2013 07:18:24 -0700	[thread overview]
Message-ID: <1373379515-28596-5-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1373379515-28596-1-git-send-email-rth@twiddle.net>

Reviewed-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 tcg/ppc/tcg-target.c | 14 --------------
 tcg/ppc/tcg-target.h |  2 +-
 2 files changed, 1 insertion(+), 15 deletions(-)

diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c
index 29ca934..453ab6b 100644
--- a/tcg/ppc/tcg-target.c
+++ b/tcg/ppc/tcg-target.c
@@ -1671,18 +1671,6 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, const TCGArg *args,
         tcg_out32 (s, DIVWU | TAB (args[0], args[1], args[2]));
         break;
 
-    case INDEX_op_rem_i32:
-        tcg_out32 (s, DIVW | TAB (0, args[1], args[2]));
-        tcg_out32 (s, MULLW | TAB (0, 0, args[2]));
-        tcg_out32 (s, SUBF | TAB (args[0], 0, args[1]));
-        break;
-
-    case INDEX_op_remu_i32:
-        tcg_out32 (s, DIVWU | TAB (0, args[1], args[2]));
-        tcg_out32 (s, MULLW | TAB (0, 0, args[2]));
-        tcg_out32 (s, SUBF | TAB (args[0], 0, args[1]));
-        break;
-
     case INDEX_op_mulu2_i32:
         if (args[0] == args[2] || args[0] == args[3]) {
             tcg_out32 (s, MULLW | TAB (0, args[2], args[3]));
@@ -1992,8 +1980,6 @@ static const TCGTargetOpDef ppc_op_defs[] = {
     { INDEX_op_mul_i32, { "r", "r", "ri" } },
     { INDEX_op_div_i32, { "r", "r", "r" } },
     { INDEX_op_divu_i32, { "r", "r", "r" } },
-    { INDEX_op_rem_i32, { "r", "r", "r" } },
-    { INDEX_op_remu_i32, { "r", "r", "r" } },
     { INDEX_op_mulu2_i32, { "r", "r", "r", "r" } },
     { INDEX_op_sub_i32, { "r", "r", "ri" } },
     { INDEX_op_and_i32, { "r", "r", "ri" } },
diff --git a/tcg/ppc/tcg-target.h b/tcg/ppc/tcg-target.h
index 01b880e..b42d97c 100644
--- a/tcg/ppc/tcg-target.h
+++ b/tcg/ppc/tcg-target.h
@@ -78,7 +78,7 @@ typedef enum {
 
 /* optional instructions */
 #define TCG_TARGET_HAS_div_i32          1
-#define TCG_TARGET_HAS_rem_i32          1
+#define TCG_TARGET_HAS_rem_i32          0
 #define TCG_TARGET_HAS_rot_i32          1
 #define TCG_TARGET_HAS_ext8s_i32        1
 #define TCG_TARGET_HAS_ext16s_i32       1
-- 
1.8.1.4

  parent reply	other threads:[~2013-07-09 14:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-09 14:18 [Qemu-devel] [PULL 00/15] tcg: remainder and tcg-arm updates Richard Henderson
2013-07-09 14:18 ` [Qemu-devel] [PULL 01/15] tcg: Add myself to general TCG maintainership Richard Henderson
2013-07-09 14:18 ` [Qemu-devel] [PULL 02/15] tcg: Split rem requirement from div requirement Richard Henderson
2013-07-09 14:18 ` [Qemu-devel] [PULL 03/15] tcg-arm: Don't implement rem Richard Henderson
2013-07-09 14:18 ` Richard Henderson [this message]
2013-07-09 14:18 ` [Qemu-devel] [PULL 05/15] tcg-ppc64: " Richard Henderson
2013-07-09 14:18 ` [Qemu-devel] [PULL 06/15] tcg: Allow non-constant control macros Richard Henderson
2013-07-09 14:18 ` [Qemu-devel] [PULL 07/15] tcg: Simplify logic using TCG_OPF_NOT_PRESENT Richard Henderson
2013-07-09 14:18 ` [Qemu-devel] [PULL 08/15] tcg-arm: Make use of conditional availability of opcodes for divide Richard Henderson
2013-07-09 14:18 ` [Qemu-devel] [PULL 09/15] tcg-arm: Rename use_armv5_instructions to use_armvt5_instructions Richard Henderson
2013-07-09 14:18 ` [Qemu-devel] [PULL 10/15] tcg-arm: Simplify logic in detecting the ARM ISA in use Richard Henderson
2013-07-09 14:18 ` [Qemu-devel] [PULL 11/15] tcg-arm: Use AT_PLATFORM to detect the host ISA Richard Henderson
2013-07-09 14:18 ` [Qemu-devel] [PULL 12/15] tcg: Fix high_pc fields in .debug_info Richard Henderson
2013-07-09 14:18 ` [Qemu-devel] [PULL 13/15] tcg: Move the CIE and FDE header definitions to common code Richard Henderson
2013-07-09 14:18 ` [Qemu-devel] [PULL 14/15] tcg-i386: Use QEMU_BUILD_BUG_ON instead of assert for frame size Richard Henderson
2013-07-09 14:18 ` [Qemu-devel] [PULL 15/15] tcg-arm: Implement tcg_register_jit Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1373379515-28596-5-git-send-email-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).