qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Dominik Dingel <dingel@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Alexander Graf <agraf@suse.de>,
	Dominik Dingel <dingel@linux.vnet.ibm.com>,
	Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH] Enable async page faults
Date: Tue,  9 Jul 2013 17:47:46 +0200	[thread overview]
Message-ID: <1373384866-36233-2-git-send-email-dingel@linux.vnet.ibm.com> (raw)
In-Reply-To: <1373384866-36233-1-git-send-email-dingel@linux.vnet.ibm.com>

S390 can also use async page faults, to enhance guest scheduling.
But in the case of live migration we want to disable the feature and know
if there are still notifications in flight.

Signed-off-by: Dominik Dingel <dingel@linux.vnet.ibm.com>
---
 target-s390x/kvm.c | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c
index 42f758f..61df7d4 100644
--- a/target-s390x/kvm.c
+++ b/target-s390x/kvm.c
@@ -36,6 +36,7 @@
 #include "sysemu/device_tree.h"
 #include "qapi/qmp/qjson.h"
 #include "monitor/monitor.h"
+#include "migration/migration.h"
 
 /* #define DEBUG_KVM */
 
@@ -92,9 +93,50 @@ const KVMCapabilityInfo kvm_arch_required_capabilities[] = {
 
 static int cap_sync_regs;
 
+static int apf_disable(QEMUFile *f, void *opaque)
+{
+    kvm_vm_ioctl(opaque, KVM_S390_APF_DISABLE);
+    return 0;
+}
+
+static void apf_enable(void *opaque)
+{
+    kvm_vm_ioctl(opaque, KVM_S390_APF_ENABLE);
+}
+
+static int apf_finish(QEMUFile *f, void *opaque, int version_id)
+{
+    apf_enable(opaque);
+    return 0;
+}
+
+static uint64_t apf_status(QEMUFile *f, void *opaque, uint64_t max_size)
+{
+    uint64_t rc = 0;
+
+    if (kvm_vm_ioctl(opaque, KVM_S390_APF_STATUS) !=
+        KVM_S390_APF_DISABLED_NON_PENDING) {
+        rc = 0xff0000;
+    }
+    return rc;
+}
+
+SaveVMHandlers savevm_apf_handlers = {
+    .save_live_setup = apf_disable,
+    .save_live_iterate = NULL,
+    .save_live_complete = NULL,
+    .save_live_pending = apf_status,
+    .load_state = apf_finish,
+    .cancel = apf_enable,
+};
+
 int kvm_arch_init(KVMState *s)
 {
     cap_sync_regs = kvm_check_extension(s, KVM_CAP_SYNC_REGS);
+    if (kvm_check_extension(s, KVM_CAP_ASYNC_PF)) {
+        register_savevm_live(NULL, "apf", -1, 1, &savevm_apf_handlers, s);
+        kvm_vm_ioctl(s, KVM_S390_APF_ENABLE);
+    }
     return 0;
 }
 
-- 
1.8.2.2

  reply	other threads:[~2013-07-09 15:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-09 15:47 [Qemu-devel] [PATCH] s390: Async page fault control Dominik Dingel
2013-07-09 15:47 ` Dominik Dingel [this message]
2013-07-10  0:59   ` [Qemu-devel] [PATCH] Enable async page faults Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1373384866-36233-2-git-send-email-dingel@linux.vnet.ibm.com \
    --to=dingel@linux.vnet.ibm.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).