From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH qom-cpu v3 08/41] gdbstub: Update gdb_handlesig() and gdb_signalled() Coding Style
Date: Wed, 10 Jul 2013 00:23:27 +0200 [thread overview]
Message-ID: <1373408640-6046-9-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1373408640-6046-1-git-send-email-afaerber@suse.de>
In particular reindent to 4 instead of 2 spaces.
Prepares for changing cpu_single_step() argument in gdb_handlesig().
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
gdbstub.c | 94 +++++++++++++++++++++++++++++++--------------------------------
1 file changed, 47 insertions(+), 47 deletions(-)
diff --git a/gdbstub.c b/gdbstub.c
index 55d4756..6ddff91 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -2761,66 +2761,66 @@ gdb_queuesig (void)
}
int
-gdb_handlesig (CPUArchState *env, int sig)
+gdb_handlesig(CPUArchState *env, int sig)
{
- GDBState *s;
- char buf[256];
- int n;
+ GDBState *s;
+ char buf[256];
+ int n;
- s = gdbserver_state;
- if (gdbserver_fd < 0 || s->fd < 0)
- return sig;
+ s = gdbserver_state;
+ if (gdbserver_fd < 0 || s->fd < 0) {
+ return sig;
+ }
- /* disable single step if it was enabled */
- cpu_single_step(env, 0);
- tb_flush(env);
+ /* disable single step if it was enabled */
+ cpu_single_step(env, 0);
+ tb_flush(env);
- if (sig != 0)
- {
- snprintf(buf, sizeof(buf), "S%02x", target_signal_to_gdb (sig));
- put_packet(s, buf);
- }
- /* put_packet() might have detected that the peer terminated the
- connection. */
- if (s->fd < 0)
- return sig;
-
- sig = 0;
- s->state = RS_IDLE;
- s->running_state = 0;
- while (s->running_state == 0) {
- n = read (s->fd, buf, 256);
- if (n > 0)
- {
- int i;
+ if (sig != 0) {
+ snprintf(buf, sizeof(buf), "S%02x", target_signal_to_gdb(sig));
+ put_packet(s, buf);
+ }
+ /* put_packet() might have detected that the peer terminated the
+ connection. */
+ if (s->fd < 0) {
+ return sig;
+ }
- for (i = 0; i < n; i++)
- gdb_read_byte (s, buf[i]);
- }
- else if (n == 0 || errno != EAGAIN)
- {
- /* XXX: Connection closed. Should probably wait for another
- connection before continuing. */
- return sig;
+ sig = 0;
+ s->state = RS_IDLE;
+ s->running_state = 0;
+ while (s->running_state == 0) {
+ n = read(s->fd, buf, 256);
+ if (n > 0) {
+ int i;
+
+ for (i = 0; i < n; i++) {
+ gdb_read_byte(s, buf[i]);
+ }
+ } else if (n == 0 || errno != EAGAIN) {
+ /* XXX: Connection closed. Should probably wait for another
+ connection before continuing. */
+ return sig;
}
- }
- sig = s->signal;
- s->signal = 0;
- return sig;
+ }
+ sig = s->signal;
+ s->signal = 0;
+ return sig;
}
/* Tell the remote gdb that the process has exited due to SIG. */
void gdb_signalled(CPUArchState *env, int sig)
{
- GDBState *s;
- char buf[4];
+ GDBState *s;
+ char buf[4];
- s = gdbserver_state;
- if (gdbserver_fd < 0 || s->fd < 0)
- return;
+ s = gdbserver_state;
+ if (gdbserver_fd < 0 || s->fd < 0) {
+ return;
+ }
- snprintf(buf, sizeof(buf), "X%02x", target_signal_to_gdb (sig));
- put_packet(s, buf);
+ snprintf(buf, sizeof(buf), "X%02x", target_signal_to_gdb(sig));
+ put_packet(s, buf);
}
static void gdb_accept(void)
--
1.8.1.4
next prev parent reply other threads:[~2013-07-09 22:24 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 22:23 [Qemu-devel] [PATCH qom-cpu v3 00/41] QOM CPUState, part 11: GDB stub Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 01/41] cpu: Introduce vaddr type Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 02/41] cpu: Introduce CPUClass::set_pc() for gdb_set_cpu_pc() Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 03/41] target-m68k: Implement CPUClass::set_pc() Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 04/41] target-moxie: " Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 05/41] target-unicore32: " Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 06/41] cpu: Introduce CPUClass::synchronize_from_tb() for cpu_pc_from_tb() Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 07/41] cpu: Move singlestep_enabled field from CPU_COMMON to CPUState Andreas Färber
2013-07-09 22:23 ` Andreas Färber [this message]
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 09/41] cpu: Change cpu_single_step() argument " Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 10/41] kvm: Change kvm_{insert, remove}_breakpoint() " Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 11/41] gdbstub: Change syscall callback " Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 12/41] gdbstub: Change gdb_handlesig() " Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 13/41] gdbstub: Change gdb_{read, write}_register() " Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 14/41] cpu: Turn cpu_get_phys_page_debug() into a CPUClass hook Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 15/41] exec: Change cpu_memory_rw_debug() argument to CPUState Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 16/41] cpu: Introduce CPUClass::memory_rw_debug() for target_memory_rw_debug() Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 17/41] gdbstub: Change GDBState::{c, g}_cpu and find_cpu() to CPUState Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 18/41] cpu: Move gdb_regs field from CPU_COMMON " Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 19/41] gdbstub: Change gdb_register_coprocessor() argument " Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 20/41] target-xtensa: Introduce XtensaCPU subclasses Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 21/41] gdbstub: Fix cpu_gdb_{read, write}_register() Coding Style Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 22/41] gdbstub: Drop dead code in cpu_gdb_{read, write}_register() Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 23/41] cpu: Introduce CPUState::gdb_num_regs and CPUClass::gdb_num_core_regs Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 24/41] target-i386: Move cpu_gdb_{read, write}_register() Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 25/41] target-ppc: " Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 26/41] target-sparc: " Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 27/41] target-arm: " Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 28/41] target-m68k: " Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 29/41] target-mips: " Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 30/41] target-openrisc: " Andreas Färber
2013-07-10 1:59 ` Jia Liu
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 31/41] target-sh4: " Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 32/41] target-microblaze: " Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 33/41] target-cris: " Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 34/41] target-alpha: " Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 35/41] target-s390x: " Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 36/41] target-lm32: " Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 37/41] target-xtensa: " Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 38/41] gdbstub: Replace GET_REG*() macros with gdb_get_reg*() functions Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 39/41] cpu: Introduce CPUClass::gdb_{read, write}_register() Andreas Färber
2013-07-09 22:23 ` [Qemu-devel] [PATCH qom-cpu v3 40/41] target-cris: Factor out CPUClass::gdb_read_register() hook for v10 Andreas Färber
2013-07-09 22:24 ` [Qemu-devel] [PATCH qom-cpu v3 41/41] cpu: Introduce CPUClass::gdb_core_xml_file for GDB_CORE_XML Andreas Färber
2013-07-22 14:52 ` [Qemu-devel] [PATCH qom-cpu v3 00/41] QOM CPUState, part 11: GDB stub Andreas Färber
2013-07-23 10:32 ` Max Filippov
2013-07-26 21:32 ` Andreas Färber
2013-07-26 22:17 ` Edgar E. Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373408640-6046-9-git-send-email-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).