From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50353)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1Uwl1U-0007HV-AB
	for qemu-devel@nongnu.org; Tue, 09 Jul 2013 23:24:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1Uwl1T-00010E-5m
	for qemu-devel@nongnu.org; Tue, 09 Jul 2013 23:24:56 -0400
Message-ID: <1373426679.16720.0.camel@pasglop>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Wed, 10 Jul 2013 13:24:39 +1000
In-Reply-To: <20130709072145.GI2696@voom.redhat.com>
References: <1372315560-5478-1-git-send-email-aik@ozlabs.ru>
	<1372315560-5478-15-git-send-email-aik@ozlabs.ru>
	<87hag4zy1p.fsf@codemonkey.ws> <51DB81B7.9040807@ozlabs.ru>
	<20130709072145.GI2696@voom.redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 14/17] pseries: Support for in-kernel XICS
 interrupt controller
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Paul Mackerras <paulus@samba.org>, Paolo Bonzini <pbonzini@redhat.com>, qemu-ppc@nongnu.org

On Tue, 2013-07-09 at 17:21 +1000, David Gibson wrote:
> > Did you mean missing typedef?
> 
> I think he means the kernel_style_struct_name instead of the
> QemuStyleStudlyCapsStructName.

Looks like we missed the mandatory MakeCodeFugly rule of qemu :-)

Cheers,
Ben.