From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwxIA-0000IP-2N for qemu-devel@nongnu.org; Wed, 10 Jul 2013 12:31:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwxI4-0001F9-OW for qemu-devel@nongnu.org; Wed, 10 Jul 2013 12:30:57 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38065 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwxI4-0001Ep-6I for qemu-devel@nongnu.org; Wed, 10 Jul 2013 12:30:52 -0400 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Wed, 10 Jul 2013 18:30:38 +0200 Message-Id: <1373473838-1163-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH RFC qom-cpu] linux-user: Avoid conditional cpu_reset() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Riku Voipio , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Eduardo Habkost Some CPUs reset as part of cpu_init(), some others were reset afterwards, some not at all. While some targets didn't implement a cpu_[state_]reset() function, QOM cpu_reset() is always available. There's nothing wrong with resetting twice on startup, so drop the #ifdef. Suggested-by: Peter Maydell Signed-off-by: Andreas F=C3=A4rber Cc: Eduardo Habkost --- This had been discussed as a possible cleanup for the #ifdef. I am uncertain whether we should do this since it hides the TODO item=20 of investigating ppc and sparc CPU reset. linux-user/main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 7f15d3d..e904d8c 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -3637,9 +3637,7 @@ int main(int argc, char **argv, char **envp) fprintf(stderr, "Unable to find CPU definition\n"); exit(1); } -#if defined(TARGET_SPARC) || defined(TARGET_PPC) cpu_reset(ENV_GET_CPU(env)); -#endif =20 thread_cpu =3D ENV_GET_CPU(env); =20 --=20 1.8.1.4