qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com
Subject: [Qemu-devel] [PULL 1/6] qemu-char: Fix ringbuf option size
Date: Wed, 10 Jul 2013 13:52:42 -0400	[thread overview]
Message-ID: <1373478767-20965-2-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1373478767-20965-1-git-send-email-lcapitulino@redhat.com>

From: Markus Armbruster <armbru@redhat.com>

Any attempt to use it trips an "opt->desc->type == QEMU_OPT_NUMBER"
assertion.  Broken in commit 1da48c65.

Cc: qemu-stable@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 qemu-char.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qemu-char.c b/qemu-char.c
index 18c42a3..800d6a6 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -3115,7 +3115,7 @@ static void qemu_chr_parse_memory(QemuOpts *opts, ChardevBackend *backend,
 
     backend->memory = g_new0(ChardevMemory, 1);
 
-    val = qemu_opt_get_number(opts, "size", 0);
+    val = qemu_opt_get_size(opts, "size", 0);
     if (val != 0) {
         backend->memory->has_size = true;
         backend->memory->size = val;
-- 
1.8.1.4

  reply	other threads:[~2013-07-10 17:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-10 17:52 [Qemu-devel] [PULL 0/6] QMP queue Luiz Capitulino
2013-07-10 17:52 ` Luiz Capitulino [this message]
2013-07-10 17:52 ` [Qemu-devel] [PULL 2/6] qapi.py: Avoid code duplication Luiz Capitulino
2013-07-10 17:52 ` [Qemu-devel] [PULL 3/6] qapi.py: Allow top-level type reference for command definitions Luiz Capitulino
2013-07-10 17:52 ` [Qemu-devel] [PULL 4/6] qapi-schema: Use BlockdevSnapshot type for blockdev-snapshot-sync Luiz Capitulino
2013-07-10 17:52 ` [Qemu-devel] [PULL 5/6] qapi-schema: Use existing type for drive-backup arguments Luiz Capitulino
2013-07-10 17:52 ` [Qemu-devel] [PULL 6/6] add timestamp to error_report() Luiz Capitulino
2013-07-12  6:58   ` Paolo Bonzini
2013-07-12 12:46     ` Luiz Capitulino
2013-07-12 14:23       ` Seiji Aguchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1373478767-20965-2-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).