qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com
Subject: [Qemu-devel] [PULL 4/6] qapi-schema: Use BlockdevSnapshot type for blockdev-snapshot-sync
Date: Wed, 10 Jul 2013 13:52:45 -0400	[thread overview]
Message-ID: <1373478767-20965-5-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1373478767-20965-1-git-send-email-lcapitulino@redhat.com>

From: Kevin Wolf <kwolf@redhat.com>

We don't have to duplicate the definition any more now that we may refer
to a type instead.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 qapi-schema.json | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/qapi-schema.json b/qapi-schema.json
index 5c32528..a90aeb1 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -1709,16 +1709,7 @@
 #
 # Generates a synchronous snapshot of a block device.
 #
-# @device:  the name of the device to generate the snapshot from.
-#
-# @snapshot-file: the target of the new image. If the file exists, or if it
-#                 is a device, the snapshot will be created in the existing
-#                 file/device. If does not exist, a new file will be created.
-#
-# @format: #optional the format of the snapshot image, default is 'qcow2'.
-#
-# @mode: #optional whether and how QEMU should create a new image, default is
-#        'absolute-paths'.
+# For the arguments, see the documentation of BlockdevSnapshot.
 #
 # Returns: nothing on success
 #          If @device is not a valid block device, DeviceNotFound
@@ -1726,8 +1717,7 @@
 # Since 0.14.0
 ##
 { 'command': 'blockdev-snapshot-sync',
-  'data': { 'device': 'str', 'snapshot-file': 'str', '*format': 'str',
-            '*mode': 'NewImageMode'} }
+  'data': 'BlockdevSnapshot' }
 
 ##
 # @human-monitor-command:
-- 
1.8.1.4

  parent reply	other threads:[~2013-07-10 17:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-10 17:52 [Qemu-devel] [PULL 0/6] QMP queue Luiz Capitulino
2013-07-10 17:52 ` [Qemu-devel] [PULL 1/6] qemu-char: Fix ringbuf option size Luiz Capitulino
2013-07-10 17:52 ` [Qemu-devel] [PULL 2/6] qapi.py: Avoid code duplication Luiz Capitulino
2013-07-10 17:52 ` [Qemu-devel] [PULL 3/6] qapi.py: Allow top-level type reference for command definitions Luiz Capitulino
2013-07-10 17:52 ` Luiz Capitulino [this message]
2013-07-10 17:52 ` [Qemu-devel] [PULL 5/6] qapi-schema: Use existing type for drive-backup arguments Luiz Capitulino
2013-07-10 17:52 ` [Qemu-devel] [PULL 6/6] add timestamp to error_report() Luiz Capitulino
2013-07-12  6:58   ` Paolo Bonzini
2013-07-12 12:46     ` Luiz Capitulino
2013-07-12 14:23       ` Seiji Aguchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1373478767-20965-5-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).