From: Dario Faggioli <dario.faggioli@citrix.com>
To: Fabio Fantoni <fabio.fantoni@m2r.biz>
Cc: xen-devel@lists.xensource.com, Ian.Campbell@citrix.com,
Stefano.Stabellini@eu.citrix.com, George.Dunlap@eu.citrix.com,
wei.lui2@citrix.com, Ian.Jackson@eu.citrix.com,
qemu-devel@nongnu.org, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [Xen-devel] [PATCH v2] libxl: usb2 and usb3 controller support for upstream qemu
Date: Thu, 11 Jul 2013 17:56:05 +0200 [thread overview]
Message-ID: <1373558165.12772.40.camel@Solace> (raw)
In-Reply-To: <1373538837-4811-1-git-send-email-fabio.fantoni@m2r.biz>
[-- Attachment #1: Type: text/plain, Size: 1588 bytes --]
On gio, 2013-07-11 at 12:33 +0200, Fabio Fantoni wrote:
> Usage: usbversion=1|2|3 (default=2)
> Specifies the type of an emulated USB bus in the guest. 1 for usb1,
> 2 for usb2 and 3 for usb3, it is available only with upstream qemu.
> Default is 2.
>
> Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
>
> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> index d218a2d..b4c6921 100644
> --- a/tools/libxl/libxl_types.idl
> +++ b/tools/libxl/libxl_types.idl
> @@ -325,6 +325,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
> ("serial", string),
> ("boot", string),
> ("usb", libxl_defbool),
> + ("usbversion", integer),
> # usbdevice:
> # - "tablet" for absolute mouse,
> # - "mouse" for PS/2 protocol relative mouse
>
I believe this calls for a `#define LIBXL_HAVE_USBVERSION' (or something
like that) in libxl.h, doesn't it?
See the comment about "libxl API compatibility" in libxl.h itself for
more details.
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-07-11 15:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 10:33 [Qemu-devel] [PATCH v2] libxl: usb2 and usb3 controller support for upstream qemu Fabio Fantoni
2013-07-11 15:56 ` Dario Faggioli [this message]
2013-07-12 8:43 ` [Qemu-devel] [Xen-devel] " Fabio Fantoni
2013-07-12 12:13 ` Dario Faggioli
2013-07-12 9:08 ` Wei Liu
2013-07-12 9:17 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373558165.12772.40.camel@Solace \
--to=dario.faggioli@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=fabio.fantoni@m2r.biz \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wei.lui2@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).