From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49341) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UxJE8-0007w3-DB for qemu-devel@nongnu.org; Thu, 11 Jul 2013 11:56:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UxJE2-0002Ui-Nv for qemu-devel@nongnu.org; Thu, 11 Jul 2013 11:56:16 -0400 Received: from smtp.eu.citrix.com ([46.33.159.39]:24894) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UxJE2-0002U1-Hh for qemu-devel@nongnu.org; Thu, 11 Jul 2013 11:56:10 -0400 Message-ID: <1373558165.12772.40.camel@Solace> From: Dario Faggioli Date: Thu, 11 Jul 2013 17:56:05 +0200 In-Reply-To: <1373538837-4811-1-git-send-email-fabio.fantoni@m2r.biz> References: <1373538837-4811-1-git-send-email-fabio.fantoni@m2r.biz> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-RpDYRa22omHmo6hEoK9a" MIME-Version: 1.0 Subject: Re: [Qemu-devel] [Xen-devel] [PATCH v2] libxl: usb2 and usb3 controller support for upstream qemu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fabio Fantoni Cc: xen-devel@lists.xensource.com, Ian.Campbell@citrix.com, Stefano.Stabellini@eu.citrix.com, George.Dunlap@eu.citrix.com, wei.lui2@citrix.com, Ian.Jackson@eu.citrix.com, qemu-devel@nongnu.org, pbonzini@redhat.com --=-RpDYRa22omHmo6hEoK9a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On gio, 2013-07-11 at 12:33 +0200, Fabio Fantoni wrote: > Usage: usbversion=3D1|2|3 (default=3D2) > Specifies the type of an emulated USB bus in the guest. 1 for usb1, > 2 for usb2 and 3 for usb3, it is available only with upstream qemu. > Default is 2. >=20 > Signed-off-by: Fabio Fantoni > > diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl > index d218a2d..b4c6921 100644 > --- a/tools/libxl/libxl_types.idl > +++ b/tools/libxl/libxl_types.idl > @@ -325,6 +325,7 @@ libxl_domain_build_info =3D Struct("domain_build_info= ",[ > ("serial", string), > ("boot", string), > ("usb", libxl_defboo= l), > + ("usbversion", integ= er), > # usbdevice: > # - "tablet" for absolute mouse, > # - "mouse" for PS/2 protocol rel= ative mouse > I believe this calls for a `#define LIBXL_HAVE_USBVERSION' (or something like that) in libxl.h, doesn't it? See the comment about "libxl API compatibility" in libxl.h itself for more details. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-RpDYRa22omHmo6hEoK9a Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) iEYEABECAAYFAlHe1ZUACgkQk4XaBE3IOsTDGQCgoFvFhjeSkEhl7/d+8o0cOcs4 +w0AoKjxupO0Zi+jZ9yM80I0nRlEGY6y =iCbC -----END PGP SIGNATURE----- --=-RpDYRa22omHmo6hEoK9a--