From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UxWvA-0006yl-RE for qemu-devel@nongnu.org; Fri, 12 Jul 2013 02:33:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UxWv9-00067A-O2 for qemu-devel@nongnu.org; Fri, 12 Jul 2013 02:33:36 -0400 Received: from mail-oa0-x233.google.com ([2607:f8b0:4003:c02::233]:47369) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UxWv9-00066e-JD for qemu-devel@nongnu.org; Fri, 12 Jul 2013 02:33:35 -0400 Received: by mail-oa0-f51.google.com with SMTP id i4so12208243oah.24 for ; Thu, 11 Jul 2013 23:33:34 -0700 (PDT) From: Liu Ping Fan Date: Fri, 12 Jul 2013 14:32:51 +0800 Message-Id: <1373610771-11819-1-git-send-email-pingfank@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH] atomic: using memory_order_relaxed for refcnt inc/dec ops List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini Refcnt's atomic inc/dec ops are frequent and its idiom need no seq_cst order. So to get better performance, it worth to adopt _relaxed other than _seq_cst memory model on them. We resort to gcc builtins. If gcc supports C11 memory model, __atomic_* buitlins is used, otherwise __sync_* builtins. Signed-off-by: Liu Ping Fan --- include/qemu/atomic.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/include/qemu/atomic.h b/include/qemu/atomic.h index 0aa8913..1f474b7 100644 --- a/include/qemu/atomic.h +++ b/include/qemu/atomic.h @@ -183,8 +183,15 @@ #endif /* Provide shorter names for GCC atomic builtins. */ +#ifndef _GLIBCXX_ATOMIC_BUILTINS +/* close to C11 memory_order_seq_cst */ #define atomic_fetch_inc(ptr) __sync_fetch_and_add(ptr, 1) #define atomic_fetch_dec(ptr) __sync_fetch_and_add(ptr, -1) +#else +/* C11 memory_order_relaxed */ +#define atomic_fetch_inc(ptr) __atomic_fetch_add(ptr, 1, __ATOMIC_RELAXED) +#define atomic_fetch_dec(ptr) __atomic_fetch_add(ptr, -1, __ATOMIC_RELAXED) +#endif #define atomic_fetch_add __sync_fetch_and_add #define atomic_fetch_sub __sync_fetch_and_sub #define atomic_fetch_and __sync_fetch_and_and @@ -192,8 +199,15 @@ #define atomic_cmpxchg __sync_val_compare_and_swap /* And even shorter names that return void. */ +#ifndef _GLIBCXX_ATOMIC_BUILTINS +/* close to C11 memory_order_seq_cst */ #define atomic_inc(ptr) ((void) __sync_fetch_and_add(ptr, 1)) #define atomic_dec(ptr) ((void) __sync_fetch_and_add(ptr, -1)) +#else +/* C11 memory_order_relaxed */ +#define atomic_inc(ptr) ((void) __atomic_fetch_add(ptr, 1, __ATOMIC_RELAXED)) +#define atomic_dec(ptr) ((void) __atomic_fetch_add(ptr, -1, __ATOMIC_RELAXED)) +#endif #define atomic_add(ptr, n) ((void) __sync_fetch_and_add(ptr, n)) #define atomic_sub(ptr, n) ((void) __sync_fetch_and_sub(ptr, n)) #define atomic_and(ptr, n) ((void) __sync_fetch_and_and(ptr, n)) -- 1.8.1.4