From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xensource.com, Stefano.Stabellini@eu.citrix.com,
George.Dunlap@eu.citrix.com, wei.lui2@citrix.com,
Ian.Jackson@eu.citrix.com, qemu-devel@nongnu.org,
Fabio Fantoni <fabio.fantoni@m2r.biz>,
pbonzini@redhat.com
Subject: Re: [Qemu-devel] [Xen-devel] [PATCH v2] libxl: usb2 and usb3 controller support for upstream qemu
Date: Fri, 12 Jul 2013 10:17:05 +0100 [thread overview]
Message-ID: <1373620625.12223.6.camel@hastur.hellion.org.uk> (raw)
In-Reply-To: <20130712090854.GA4409@zion.uk.xensource.com>
On Fri, 2013-07-12 at 10:08 +0100, Wei Liu wrote:
> On Thu, Jul 11, 2013 at 12:33:57PM +0200, Fabio Fantoni wrote:
> > diff --git a/tools/libxl/xl_sxp.c b/tools/libxl/xl_sxp.c
> > index a16a025..2dc3a86 100644
> > --- a/tools/libxl/xl_sxp.c
> > +++ b/tools/libxl/xl_sxp.c
> > @@ -142,6 +142,7 @@ void printf_info_sexp(int domid, libxl_domain_config *d_config)
> > printf("\t\t\t(serial %s)\n", b_info->u.hvm.serial);
> > printf("\t\t\t(boot %s)\n", b_info->u.hvm.boot);
> > printf("\t\t\t(usb %s)\n", libxl_defbool_to_string(b_info->u.hvm.usb));
> > + printf("\t\t\t(usb %d)\n", b_info->u.hvm.usbversion);
>
> Should be "usbversion".
Actually this file shouldn't be patched at all. The sxp output exists
solely for compatibility with existing scripts which expect xend and so
does not need to reflect the status of new features.
Ian.
prev parent reply other threads:[~2013-07-12 9:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 10:33 [Qemu-devel] [PATCH v2] libxl: usb2 and usb3 controller support for upstream qemu Fabio Fantoni
2013-07-11 15:56 ` [Qemu-devel] [Xen-devel] " Dario Faggioli
2013-07-12 8:43 ` Fabio Fantoni
2013-07-12 12:13 ` Dario Faggioli
2013-07-12 9:08 ` Wei Liu
2013-07-12 9:17 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373620625.12223.6.camel@hastur.hellion.org.uk \
--to=ian.campbell@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=fabio.fantoni@m2r.biz \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wei.liu2@citrix.com \
--cc=wei.lui2@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).