qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Jia Liu <proljc@gmail.com>,
	patches@linaro.org, Riku Voipio <riku.voipio@iki.fi>,
	Alexander Graf <agraf@suse.de>, Blue Swirl <blauwirbel@gmail.com>,
	Paul Brook <paul@codesourcery.com>,
	Guan Xuetao <gxt@mprc.pku.edu.cn>,
	Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PATCH 7/8] linux-user: Enable NPTL for SPARC targets
Date: Fri, 12 Jul 2013 21:12:52 +0100	[thread overview]
Message-ID: <1373659973-23289-8-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1373659973-23289-1-git-send-email-peter.maydell@linaro.org>

Provide the missing cpu_set_tls(), and resolve the FIXME in
cpu_clone_regs() by clearing the carry flag for the child.
This allows us to turn on building with NPTL for SPARC.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 configure                     |    3 ---
 linux-user/sparc/target_cpu.h |   16 ++++++++++++----
 2 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/configure b/configure
index 3848c1c..117191e 100755
--- a/configure
+++ b/configure
@@ -4255,18 +4255,15 @@ case "$target_name" in
     bflt="yes"
   ;;
   sparc)
-    target_nptl="no"
   ;;
   sparc64)
     TARGET_BASE_ARCH=sparc
-    target_nptl="no"
   ;;
   sparc32plus)
     TARGET_ARCH=sparc64
     TARGET_BASE_ARCH=sparc
     TARGET_ABI_DIR=sparc
     echo "TARGET_ABI32=y" >> $config_target_mak
-    target_nptl="no"
   ;;
   s390x)
   ;;
diff --git a/linux-user/sparc/target_cpu.h b/linux-user/sparc/target_cpu.h
index 5a620a2..4944d46 100644
--- a/linux-user/sparc/target_cpu.h
+++ b/linux-user/sparc/target_cpu.h
@@ -25,12 +25,20 @@ static inline void cpu_clone_regs(CPUSPARCState *env, target_ulong newsp)
     if (newsp) {
         env->regwptr[22] = newsp;
     }
+    /* syscall return for clone child: 0, and clear CF since
+     * this counts as a success return value.
+     */
     env->regwptr[0] = 0;
-    /* FIXME: Do we also need to clear CF?  */
-    /* XXXXX */
-    printf("HELPME: %s:%d\n", __FILE__, __LINE__);
+#if defined(TARGET_SPARC64) && !defined(TARGET_ABI32)
+    env->xcc &= ~PSR_CARRY;
+#else
+    env->psr &= ~PSR_CARRY;
+#endif
 }
 
-/* TODO: need to implement cpu_set_tls() */
+static inline void cpu_set_tls(CPUSPARCState *env, target_ulong newtls)
+{
+    env->gregs[7] = newtls;
+}
 
 #endif
-- 
1.7.9.5

  parent reply	other threads:[~2013-07-12 20:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-12 20:12 [Qemu-devel] [PATCH 0/8] linux-user: enable NPTL on everything but x86 Peter Maydell
2013-07-12 20:12 ` [Qemu-devel] [PATCH 1/8] configure: Flip default of target_nptl Peter Maydell
2013-07-12 20:12 ` [Qemu-devel] [PATCH 2/8] configure: Don't say target_nptl="no" if there is no linux-user target Peter Maydell
2013-07-12 20:12 ` [Qemu-devel] [PATCH 3/8] configure: Enable threading on all ppc and mips linux-user targets Peter Maydell
2013-07-12 20:12 ` [Qemu-devel] [PATCH 4/8] configure: Enable threading for unicore32-linux-user Peter Maydell
2013-07-12 20:12 ` [Qemu-devel] [PATCH 5/8] linux-user: Move includes of target-specific headers to end of qemu.h Peter Maydell
2013-07-13 21:01   ` Richard Henderson
2013-07-12 20:12 ` [Qemu-devel] [PATCH 6/8] linux-user: Enable NPTL for OpenRISC Peter Maydell
2013-07-13  7:40   ` Jia Liu
2013-07-13  8:04     ` Peter Maydell
2013-07-12 20:12 ` Peter Maydell [this message]
2013-07-13 21:01   ` [Qemu-devel] [PATCH 7/8] linux-user: Enable NPTL for SPARC targets Richard Henderson
2013-07-12 20:12 ` [Qemu-devel] [PATCH 8/8] linux-user: Enable NPTL for m68k Peter Maydell
2013-07-13 10:28   ` Laurent Vivier
2013-07-13 11:35     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1373659973-23289-8-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=agraf@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=blauwirbel@gmail.com \
    --cc=gxt@mprc.pku.edu.cn \
    --cc=patches@linaro.org \
    --cc=paul@codesourcery.com \
    --cc=proljc@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).