From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44823) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyfJO-0008Fl-QF for qemu-devel@nongnu.org; Mon, 15 Jul 2013 05:43:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UyfJM-0002oJ-5l for qemu-devel@nongnu.org; Mon, 15 Jul 2013 05:43:18 -0400 Received: from mail-pd0-x22b.google.com ([2607:f8b0:400e:c02::22b]:65498) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyfJM-0002nu-0E for qemu-devel@nongnu.org; Mon, 15 Jul 2013 05:43:16 -0400 Received: by mail-pd0-f171.google.com with SMTP id y14so10520299pdi.2 for ; Mon, 15 Jul 2013 02:43:15 -0700 (PDT) From: Xu Wang Date: Mon, 15 Jul 2013 05:42:32 -0400 Message-Id: <1373881356-3294-4-git-send-email-cngesaint@gmail.com> In-Reply-To: <1373881356-3294-1-git-send-email-cngesaint@gmail.com> References: <1373881356-3294-1-git-send-email-cngesaint@gmail.com> Subject: [Qemu-devel] [PATCH V3 3/7] block: Check infinite loop in bdrv_img_create() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, stefanha@gmail.com, wdongxu@linux.vnet.ibm.com, Xu Wang , xiawenc@linux.vnet.ibm.com Backing file loop should be checked before qemu-img create command execution. If loop was found, qemu-img create should be stopped and an error was printed. Signed-off-by: Xu Wang --- block.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index a06bb08..e9b9112 100644 --- a/block.c +++ b/block.c @@ -4685,15 +4685,15 @@ void bdrv_img_create(const char *filename, const char *fmt, } backing_file = get_option_parameter(param, BLOCK_OPT_BACKING_FILE); + backing_fmt = get_option_parameter(param, BLOCK_OPT_BACKING_FMT); if (backing_file && backing_file->value.s) { - if (!strcmp(filename, backing_file->value.s)) { - error_setg(errp, "Error: Trying to create an image with the " - "same filename as the backing file"); + if (bdrv_backing_file_loop_check(filename, fmt, + backing_file->value.s, + backing_fmt->value.s)) { + /* There is loop exists in the backing file chain */ goto out; } } - - backing_fmt = get_option_parameter(param, BLOCK_OPT_BACKING_FMT); if (backing_fmt && backing_fmt->value.s) { backing_drv = bdrv_find_format(backing_fmt->value.s); if (!backing_drv) { -- 1.8.1.4