From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44972) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyfJe-0000Cb-FF for qemu-devel@nongnu.org; Mon, 15 Jul 2013 05:43:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UyfJa-0002u5-0n for qemu-devel@nongnu.org; Mon, 15 Jul 2013 05:43:34 -0400 Received: from mail-pb0-x22a.google.com ([2607:f8b0:400e:c01::22a]:61588) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyfJZ-0002tp-Pj for qemu-devel@nongnu.org; Mon, 15 Jul 2013 05:43:29 -0400 Received: by mail-pb0-f42.google.com with SMTP id un1so11134345pbc.15 for ; Mon, 15 Jul 2013 02:43:29 -0700 (PDT) From: Xu Wang Date: Mon, 15 Jul 2013 05:42:34 -0400 Message-Id: <1373881356-3294-6-git-send-email-cngesaint@gmail.com> In-Reply-To: <1373881356-3294-1-git-send-email-cngesaint@gmail.com> References: <1373881356-3294-1-git-send-email-cngesaint@gmail.com> Subject: [Qemu-devel] [PATCH V3 5/7] block: Add infinite loop check in drive_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, stefanha@gmail.com, wdongxu@linux.vnet.ibm.com, Xu Wang , xiawenc@linux.vnet.ibm.com Backing file should be checked if there is a loop in it during image boot. Becase if there is loop qemu would no response for a long time and segment fault occured. So this patch would check backing file chain if there is loop in it before open image. Signed-off-by: Xu Wang --- blockdev.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/blockdev.c b/blockdev.c index b3a57e0..b5f063f 100644 --- a/blockdev.c +++ b/blockdev.c @@ -695,6 +695,12 @@ DriveInfo *drive_init(QemuOpts *all_opts, BlockInterfaceType block_default_type) error_report("warning: disabling copy_on_read on readonly drive"); } + /* Add backing file loop check */ + if (bdrv_backing_file_loop_check(file, drv ? drv->format_name : NULL, + NULL, NULL)) { + goto err; + } + ret = bdrv_open(dinfo->bdrv, file, bs_opts, bdrv_flags, drv); bs_opts = NULL; -- 1.8.1.4